components/dom_distiller/content/web_contents_main_frame_observer.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/web_contents_main_frame_observer.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/dom_distiller_viewer_source.cc ('k') | components/dom_distiller/core/distilled_content_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/web_contents_main_frame_observer.h

diff --git a/components/dom_distiller/content/web_contents_main_frame_observer.h b/components/dom_distiller/content/web_contents_main_frame_observer.h

index 7d9a85b8f9c43175db588bf53f49f3e9765e9c32..e1a62990a528686fa4547a07433093509e74f319 100644

--- a/components/dom_distiller/content/web_contents_main_frame_observer.h

+++ b/components/dom_distiller/content/web_contents_main_frame_observer.h

@@ -18,7 +18,7 @@ class WebContentsMainFrameObserver

: public content::WebContentsObserver,

public content::WebContentsUserData<WebContentsMainFrameObserver> {

public:

- virtual ~WebContentsMainFrameObserver();

+ ~WebContentsMainFrameObserver() override;

bool is_document_loaded_in_main_frame() {

return is_document_loaded_in_main_frame_;

@@ -27,12 +27,12 @@ class WebContentsMainFrameObserver

bool is_initialized() { return is_initialized_; }

// content::WebContentsObserver implementation.

- virtual void DocumentLoadedInFrame(

+ void DocumentLoadedInFrame(

content::RenderFrameHost* render_frame_host) override;

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- virtual void RenderProcessGone(base::TerminationStatus status) override;

+ void RenderProcessGone(base::TerminationStatus status) override;

private:

explicit WebContentsMainFrameObserver(content::WebContents* web_contents);