Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: components/dom_distiller/content/dom_distiller_viewer_source.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/dom_distiller_viewer_source.cc
diff --git a/components/dom_distiller/content/dom_distiller_viewer_source.cc b/components/dom_distiller/content/dom_distiller_viewer_source.cc
index 9c844d6c3d8ad8088e4fdb23fe577ebea47505d4..5d6bb6ab55b1b795dda437b9681446ae4ecd8ff4 100644
--- a/components/dom_distiller/content/dom_distiller_viewer_source.cc
+++ b/components/dom_distiller/content/dom_distiller_viewer_source.cc
@@ -44,25 +44,23 @@ class DomDistillerViewerSource::RequestViewerHandle
const std::string& expected_request_path,
const content::URLDataSource::GotDataCallback& callback,
DistilledPagePrefs* distilled_page_prefs);
- virtual ~RequestViewerHandle();
+ ~RequestViewerHandle() override;
// ViewRequestDelegate implementation:
- virtual void OnArticleReady(
- const DistilledArticleProto* article_proto) override;
+ void OnArticleReady(const DistilledArticleProto* article_proto) override;
- virtual void OnArticleUpdated(
- ArticleDistillationUpdate article_update) override;
+ void OnArticleUpdated(ArticleDistillationUpdate article_update) override;
void TakeViewerHandle(scoped_ptr<ViewerHandle> viewer_handle);
// content::WebContentsObserver implementation:
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void RenderProcessGone(base::TerminationStatus status) override;
- virtual void WebContentsDestroyed() override;
- virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url) override;
+ void RenderProcessGone(base::TerminationStatus status) override;
+ void WebContentsDestroyed() override;
+ void DidFinishLoad(content::RenderFrameHost* render_frame_host,
+ const GURL& validated_url) override;
private:
// Sends JavaScript to the attached Viewer, buffering data if the viewer isn't
@@ -75,9 +73,9 @@ class DomDistillerViewerSource::RequestViewerHandle
void Cancel();
// DistilledPagePrefs::Observer implementation:
- virtual void OnChangeFontFamily(
+ void OnChangeFontFamily(
DistilledPagePrefs::FontFamily new_font_family) override;
- virtual void OnChangeTheme(DistilledPagePrefs::Theme new_theme) override;
+ void OnChangeTheme(DistilledPagePrefs::Theme new_theme) override;
// The handle to the view request towards the DomDistillerService. It
// needs to be kept around to ensure the distillation request finishes.

Powered by Google App Engine
This is Rietveld 408576698