Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: components/copresence/rpc/rpc_handler_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/copresence/rpc/http_post.h ('k') | components/copresence_sockets/copresence_peer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/copresence/rpc/rpc_handler_unittest.cc
diff --git a/components/copresence/rpc/rpc_handler_unittest.cc b/components/copresence/rpc/rpc_handler_unittest.cc
index 77d61cb6f85f6d6a3aa3ad4974e7cba4b4103ab1..aad39e3f059b168706f682d644b973435ccaeaa2 100644
--- a/components/copresence/rpc/rpc_handler_unittest.cc
+++ b/components/copresence/rpc/rpc_handler_unittest.cc
@@ -40,21 +40,21 @@ void CreateSubscribedMessage(const std::vector<std::string>& subscription_ids,
class FakeDirectiveHandler : public DirectiveHandler {
public:
FakeDirectiveHandler() {}
- virtual ~FakeDirectiveHandler() {}
+ ~FakeDirectiveHandler() override {}
const std::vector<Directive>& added_directives() const {
return added_directives_;
}
- virtual void Initialize(
+ void Initialize(
const AudioRecorder::DecodeSamplesCallback& decode_cb,
const AudioDirectiveHandler::EncodeTokenCallback& encode_cb) override {}
- virtual void AddDirective(const Directive& directive) override {
+ void AddDirective(const Directive& directive) override {
added_directives_.push_back(directive);
}
- virtual void RemoveDirectives(const std::string& op_id) override {
+ void RemoveDirectives(const std::string& op_id) override {
// TODO(ckehoe): Add a parallel implementation when prod has one.
}
@@ -137,29 +137,24 @@ class RpcHandlerTest : public testing::Test, public CopresenceDelegate {
// CopresenceDelegate implementation
- virtual void HandleMessages(
- const std::string& app_id,
- const std::string& subscription_id,
- const std::vector<Message>& messages) override {
+ void HandleMessages(const std::string& app_id,
+ const std::string& subscription_id,
+ const std::vector<Message>& messages) override {
// app_id is unused for now, pending a server fix.
messages_by_subscription_[subscription_id] = messages;
}
- virtual net::URLRequestContextGetter* GetRequestContext() const override {
+ net::URLRequestContextGetter* GetRequestContext() const override {
return NULL;
}
- virtual const std::string GetPlatformVersionString() const override {
+ const std::string GetPlatformVersionString() const override {
return kChromeVersion;
}
- virtual const std::string GetAPIKey() const override {
- return api_key_;
- }
+ const std::string GetAPIKey() const override { return api_key_; }
- virtual WhispernetClient* GetWhispernetClient() override {
- return NULL;
- }
+ WhispernetClient* GetWhispernetClient() override { return NULL; }
protected:
// For rpc_handler_.invalid_audio_token_cache_
« no previous file with comments | « components/copresence/rpc/http_post.h ('k') | components/copresence_sockets/copresence_peer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698