components/copresence/rpc/http_post.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/rpc/http_post.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/copresence/mediums/audio/audio_recorder_unittest.cc ('k') | components/copresence/rpc/rpc_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/rpc/http_post.h

diff --git a/components/copresence/rpc/http_post.h b/components/copresence/rpc/http_post.h

index f324b69066d76d5b51739de7169bbc885e6b34ba..83a39c01cfd24d5507d6f87209710f6a552f531d 100644

--- a/components/copresence/rpc/http_post.h

+++ b/components/copresence/rpc/http_post.h

@@ -47,7 +47,7 @@ class HttpPost : public net::URLFetcherDelegate {

const google::protobuf::MessageLite& request_proto);

// HTTP requests are cancelled on delete.

- virtual ~HttpPost();

+ ~HttpPost() override;

// Send an HttpPost request.

void Start(const ResponseCallback& response_callback);

@@ -60,7 +60,7 @@ class HttpPost : public net::URLFetcherDelegate {

friend class HttpPostTest;

// Overridden from net::URLFetcherDelegate.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

ResponseCallback response_callback_;