components/copresence/mediums/audio/audio_player.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/mediums/audio/audio_player.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/copresence/handlers/audio/audio_directive_handler_unittest.cc ('k') | components/copresence/mediums/audio/audio_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/mediums/audio/audio_player.h

diff --git a/components/copresence/mediums/audio/audio_player.h b/components/copresence/mediums/audio/audio_player.h

index 96c1f0f3bf1a267703b07fd221bc59b5e6993e26..e2bb64dce169199347dcdc50533b369ff5f49429 100644

--- a/components/copresence/mediums/audio/audio_player.h

+++ b/components/copresence/mediums/audio/audio_player.h

@@ -47,7 +47,7 @@ class AudioPlayer : public media::AudioOutputStream::AudioSourceCallback {

}

protected:

- virtual ~AudioPlayer();

+ ~AudioPlayer() override;

void set_is_playing(bool is_playing) { is_playing_ = is_playing; }

private:

@@ -66,9 +66,8 @@ class AudioPlayer : public media::AudioOutputStream::AudioSourceCallback {

// AudioOutputStream::AudioSourceCallback overrides:

// Following methods could be called from *ANY* thread.

- virtual int OnMoreData(media::AudioBus* dest,

- uint32 total_bytes_delay) override;

- virtual void OnError(media::AudioOutputStream* stream) override;

+ int OnMoreData(media::AudioBus* dest, uint32 total_bytes_delay) override;

+ void OnError(media::AudioOutputStream* stream) override;

// Flushes the audio loop, making sure that any queued operations are

// performed.