components/content_settings/core/common/content_settings_pattern.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings_pattern.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_rule_unittest.cc ('k') | components/copresence/copresence_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/content_settings_pattern.cc

diff --git a/components/content_settings/core/common/content_settings_pattern.cc b/components/content_settings/core/common/content_settings_pattern.cc

index 353d7df32bc34aea3ea58e34ea4a6ca09129da65..b02cbee5dac6dad2f2e967507e0f079643f003ff 100644

--- a/components/content_settings/core/common/content_settings_pattern.cc

+++ b/components/content_settings/core/common/content_settings_pattern.cc

@@ -87,19 +87,19 @@ class ContentSettingsPattern::Builder :

public ContentSettingsPattern::BuilderInterface {

public:

explicit Builder(bool use_legacy_validate);

- virtual ~Builder();

+ ~Builder() override;

// BuilderInterface:

- virtual BuilderInterface* WithPort(const std::string& port) override;

- virtual BuilderInterface* WithPortWildcard() override;

- virtual BuilderInterface* WithHost(const std::string& host) override;

- virtual BuilderInterface* WithDomainWildcard() override;

- virtual BuilderInterface* WithScheme(const std::string& scheme) override;

- virtual BuilderInterface* WithSchemeWildcard() override;

- virtual BuilderInterface* WithPath(const std::string& path) override;

- virtual BuilderInterface* WithPathWildcard() override;

- virtual BuilderInterface* Invalid() override;

- virtual ContentSettingsPattern Build() override;

+ BuilderInterface* WithPort(const std::string& port) override;

+ BuilderInterface* WithPortWildcard() override;

+ BuilderInterface* WithHost(const std::string& host) override;

+ BuilderInterface* WithDomainWildcard() override;

+ BuilderInterface* WithScheme(const std::string& scheme) override;

+ BuilderInterface* WithSchemeWildcard() override;

+ BuilderInterface* WithPath(const std::string& path) override;

+ BuilderInterface* WithPathWildcard() override;

+ BuilderInterface* Invalid() override;

+ ContentSettingsPattern Build() override;

private:

// Canonicalizes the pattern parts so that they are ASCII only, either