components/content_settings/core/browser/content_settings_rule_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_rule_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_rule.h ('k') | components/content_settings/core/common/content_settings_pattern.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_rule_unittest.cc

diff --git a/components/content_settings/core/browser/content_settings_rule_unittest.cc b/components/content_settings/core/browser/content_settings_rule_unittest.cc

index 1d6cf316718fa08e06df87f56f03f56bbc920d36..e588596fc68e9dd30873651a6fa3403a70e5b0e1 100644

--- a/components/content_settings/core/browser/content_settings_rule_unittest.cc

+++ b/components/content_settings/core/browser/content_settings_rule_unittest.cc

@@ -17,13 +17,11 @@ class ListIterator : public RuleIterator {

explicit ListIterator(const std::list<Rule>& rules)

: rules_(rules) {}

- virtual ~ListIterator() {}

+ ~ListIterator() override {}

- virtual bool HasNext() const override {

- return !rules_.empty();

- }

+ bool HasNext() const override { return !rules_.empty(); }

- virtual Rule Next() override {

+ Rule Next() override {

EXPECT_FALSE(rules_.empty());

// |front()| returns a reference but we're going to discard the object

// referred to; force copying here.