components/component_updater/url_fetcher_downloader.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/url_fetcher_downloader.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/component_updater/update_checker.cc ('k') | components/content_settings/core/browser/content_settings_observable_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/url_fetcher_downloader.h

diff --git a/components/component_updater/url_fetcher_downloader.h b/components/component_updater/url_fetcher_downloader.h

index 7a51c206d4f554d5182cd4daf9145e77d12cb11e..99a7d3ab1036ef4874ea8f652fe5d265f74e03ba 100644

--- a/components/component_updater/url_fetcher_downloader.h

+++ b/components/component_updater/url_fetcher_downloader.h

@@ -30,17 +30,17 @@ class UrlFetcherDownloader : public CrxDownloader,

UrlFetcherDownloader(scoped_ptr<CrxDownloader> successor,

net::URLRequestContextGetter* context_getter,

scoped_refptr<base::SequencedTaskRunner> task_runner);

- virtual ~UrlFetcherDownloader();

+ ~UrlFetcherDownloader() override;

private:

// Overrides for CrxDownloader.

- virtual void DoStartDownload(const GURL& url) override;

+ void DoStartDownload(const GURL& url) override;

// Overrides for URLFetcherDelegate.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

- virtual void OnURLFetchDownloadProgress(const net::URLFetcher* source,

- int64_t current,

- int64_t total) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchDownloadProgress(const net::URLFetcher* source,

+ int64_t current,

+ int64_t total) override;

scoped_ptr<net::URLFetcher> url_fetcher_;

net::URLRequestContextGetter* context_getter_;

scoped_refptr<base::SequencedTaskRunner> task_runner_;