components/component_updater/update_checker.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/update_checker.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/component_updater/test/url_request_post_interceptor.cc ('k') | components/component_updater/url_fetcher_downloader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/update_checker.cc

diff --git a/components/component_updater/update_checker.cc b/components/component_updater/update_checker.cc

index 3bfff63980a9004ad948bd605cca3e39910b3f49..f14263c2e946452b3ad4be1c1d94bac796e2545d 100644

--- a/components/component_updater/update_checker.cc

+++ b/components/component_updater/update_checker.cc

@@ -79,10 +79,10 @@ std::string BuildUpdateCheckRequest(const Configurator& config,

class UpdateCheckerImpl : public UpdateChecker {

public:

explicit UpdateCheckerImpl(const Configurator& config);

- virtual ~UpdateCheckerImpl();

+ ~UpdateCheckerImpl() override;

// Overrides for UpdateChecker.

- virtual bool CheckForUpdates(

+ bool CheckForUpdates(

const std::vector<CrxUpdateItem*>& items_to_check,

const std::string& additional_attributes,

const UpdateCheckCallback& update_check_callback) override;