chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Horribleness Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h ('k') | chrome/browser/browsing_data/mock_browsing_data_database_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h

diff --git a/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h b/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h

index e766e78eb218531759f678a70659acc34cdea195..21031a32e019d17f5c334dfaa91210d905b18b48 100644

--- a/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h

+++ b/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h

@@ -18,9 +18,9 @@ class MockBrowsingDataCookieHelper : public BrowsingDataCookieHelper {

net::URLRequestContextGetter* request_context_getter);

// BrowsingDataCookieHelper methods.

- virtual void StartFetching(

- const net::CookieMonster::GetCookieListCallback &callback) override;

- virtual void DeleteCookie(const net::CanonicalCookie& cookie) override;

+ void StartFetching(

+ const net::CookieMonster::GetCookieListCallback& callback) override;

+ void DeleteCookie(const net::CanonicalCookie& cookie) override;

// Adds some cookie samples.

void AddCookieSamples(const GURL& url, const std::string& cookie_line);

@@ -36,7 +36,7 @@ class MockBrowsingDataCookieHelper : public BrowsingDataCookieHelper {

bool AllDeleted();

private:

- virtual ~MockBrowsingDataCookieHelper();

+ ~MockBrowsingDataCookieHelper() override;

net::CookieMonster::GetCookieListCallback callback_;