chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Horribleness Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h ('k') | chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h

diff --git a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h

index a5953d457a5f73cfb15993788ab4a194cf3b853d..96e09cb29bf4d07de6c6ef304a4334d50be93aaf 100644

--- a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h

+++ b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h

@@ -17,8 +17,8 @@ class MockBrowsingDataChannelIDHelper

MockBrowsingDataChannelIDHelper();

// BrowsingDataChannelIDHelper methods.

- virtual void StartFetching(const FetchResultCallback& callback) override;

- virtual void DeleteChannelID(const std::string& server_id) override;

+ void StartFetching(const FetchResultCallback& callback) override;

+ void DeleteChannelID(const std::string& server_id) override;

// Adds a channel_id sample.

void AddChannelIDSample(const std::string& server_id);

@@ -34,7 +34,7 @@ class MockBrowsingDataChannelIDHelper

bool AllDeleted();

private:

- virtual ~MockBrowsingDataChannelIDHelper();

+ ~MockBrowsingDataChannelIDHelper() override;

FetchResultCallback callback_;