chrome/browser/browsing_data/browsing_data_remover.h - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_appcache_helper.h ('K') | « chrome/browser/browsing_data/browsing_data_quota_helper_impl.h ('k') | chrome/browser/browsing_data/browsing_data_remover_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.h

diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h

index e7725169e20c6879af197cfb49b03fd0eca6eca1..59f1dcaef4c434d6a3c7e90311a291ef248082d7 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.h

+++ b/chrome/browser/browsing_data/browsing_data_remover.h

@@ -250,7 +250,7 @@ class BrowsingDataRemover

// to be deleted by other objects so make destructor private and DeleteHelper

// a friend.

friend class base::DeleteHelper<BrowsingDataRemover>;

- virtual ~BrowsingDataRemover();

+ ~BrowsingDataRemover() override;

dcheng 2014/10/21 09:52:50 Ugh. It turns out this is only conditionally an ov

Mike West 2014/10/21 10:08:06 Bleh. That's unfortunate. The #if/#else sounds fi

dcheng 2014/10/21 21:38:16 Done.

// Callback for when TemplateURLService has finished loading. Clears the data,

// clears the respective waiting flag, and invokes NotifyAndDeleteIfDone.

@@ -261,8 +261,8 @@ class BrowsingDataRemover

#if defined(ENABLE_PLUGINS)

// PepperFlashSettingsManager::Client implementation.

- virtual void OnDeauthorizeContentLicensesCompleted(uint32 request_id,

- bool success) override;

+ void OnDeauthorizeContentLicensesCompleted(uint32 request_id,

+ bool success) override;

#endif

#if defined (OS_CHROMEOS)