chrome/browser/browsing_data/browsing_data_appcache_helper.h - Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_appcache_helper.h

Issue 666123002: Standardize usage of virtual/override/final in chrome/browser/browsing_data/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data/browsing_data_appcache_helper.h

diff --git a/chrome/browser/browsing_data/browsing_data_appcache_helper.h b/chrome/browser/browsing_data/browsing_data_appcache_helper.h

index 9df48a8da86a30bea4b66fd0e0d747166a214839..c03c8405e51e4ac3621a2864184156f544e63c31 100644

--- a/chrome/browser/browsing_data/browsing_data_appcache_helper.h

+++ b/chrome/browser/browsing_data/browsing_data_appcache_helper.h

@@ -76,11 +76,11 @@ class CannedBrowsingDataAppCacheHelper : public BrowsingDataAppCacheHelper {

const OriginAppCacheInfoMap& GetOriginAppCacheInfoMap() const;

// BrowsingDataAppCacheHelper methods.

- virtual void StartFetching(const base::Closure& completion_callback) override;

- virtual void DeleteAppCacheGroup(const GURL& manifest_url) override;

+ void StartFetching(const base::Closure& completion_callback) override;

+ void DeleteAppCacheGroup(const GURL& manifest_url) override;

private:

- virtual ~CannedBrowsingDataAppCacheHelper();

+ ~CannedBrowsingDataAppCacheHelper() override;

Mike West 2014/10/21 09:29:39 I think this is weird. But it's what the thread co

DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataAppCacheHelper);

};

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_channel_id_helper.h » ('j') | chrome/browser/browsing_data/browsing_data_remover.h » ('J')