Enable virtual viewport on Android

Enable virtual viewport on Android.

BUG=148816
Committed: https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc
Cr-Commit-Position: refs/heads/master@{#301307}

Committed: https://crrev.com/edb0ccdf75d9133adfcf9d3ef28c81f8075a7746
Cr-Commit-Position: refs/heads/master@{#301722}

[bokan, 2014-10-23 19:11:28]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2014-10-23 19:13:07]

Need to wait until 
https://codereview.chromium.org/657063004/ and
https://codereview.chromium.org/675793002/ land so tests don't go red but
otherwise ready to go. lgtm?

[aelias_OOO_until_Jul13, 2014-10-23 19:20:28]

As part of this patch, please change --enable-pinch-virtual-viewport to
--disable-pinch-virtual-viewport.  That will make it easier to debug the
remaining issues.

[bokan, 2014-10-23 19:43:40]

On 2014/10/23 19:20:28, aelias wrote:
> As part of this patch, please change --enable-pinch-virtual-viewport to
> --disable-pinch-virtual-viewport.  That will make it easier to debug the
> remaining issues.

We already have --disable-pinch-virtual-viewport (see just above the code
change). Unless I misunderstood you.

[aelias_OOO_until_Jul13, 2014-10-23 19:49:50]

Oops, I didn't realize that.  OK, lgtm when everything is green.

[mkosiba (inactive), 2014-10-24 16:09:50]

mkosiba@chromium.org changed reviewers:
+ mkosiba@chromium.org

[mkosiba (inactive), 2014-10-24 16:09:50]

lgtm

https://codereview.chromium.org/665963002/diff/20001/android_webview/lib/main...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/665963002/diff/20001/android_webview/lib/main...
android_webview/lib/main/aw_main_delegate.cc:84:
cl->AppendSwitch(switches::kDisablePinchVirtualViewport);
please add a comment referring to http://crbug.com/426891

[bokan, 2014-10-24 16:18:47]

Ok, after offline discussion with mkosiba@, this patch now enables virtual
viewport everywhere but android webview. There's still some issues to sort out
there (crbug.com/426891). I think we should still land this, if nothing else
we'll get some real world usage. aelias@, still lgtm?

[aelias_OOO_until_Jul13, 2014-10-24 18:25:42]

lgtm

[aelias_OOO_until_Jul13, 2014-10-24 19:19:23]

One more thing, this is likely to cause Clank's private instrumentation tests to
go red, many of which perform hit tests at a particular page scale.  See
https://sites.google.com/a/google.com/clank/engineering/noogler-guide/testing...
"Instrumentation tests" tab to see how to run them locally.  If they break, it
will cause the ToT bot https://chromegw.corp.google.com/i/clank.tot/console to
go red, preventing Clank from rolling forward past this Chromium revision.

[cpu_(ooo_6.6-7.5), 2014-10-24 20:07:04]

cpu@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2014-10-24 20:07:07]

lgtm

[cpu_(ooo_6.6-7.5), 2014-10-24 20:07:45]

btw, is there a launch bug associated with this? and is this going into m40?

[bokan, 2014-10-24 20:17:16]

On 2014/10/24 20:07:45, cpu wrote:
> btw, is there a launch bug associated with this? and is this going into m40?

I believe there was a launch bug, I'll try to dig it up (though it might have
been for ChromeOS). Yes, as of now, M40 is the goal.

[bokan, 2014-10-27 00:44:43]

On 2014/10/24 19:19:23, aelias wrote:
> One more thing, this is likely to cause Clank's private instrumentation tests
to
> go red, many of which perform hit tests at a particular page scale.  See
>
https://sites.google.com/a/google.com/clank/engineering/noogler-guide/testing...
> "Instrumentation tests" tab to see how to run them locally.  If they break, it
> will cause the ToT bot https://chromegw.corp.google.com/i/clank.tot/console to
> go red, preventing Clank from rolling forward past this Chromium revision.

Ran these locally, all passed so I'll go ahead and commit this.

[bokan, 2014-10-27 00:44:49]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-10-27 00:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665963002/60001

[commit-bot: I haz the power, 2014-10-27 00:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 00:47:37]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[bokan, 2014-10-27 01:03:37]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-10-27 01:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665963002/80001

[commit-bot: I haz the power, 2014-10-27 02:17:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-27 02:17:53]

Patchset 5 (id:??) landed as
https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc
Cr-Commit-Position: refs/heads/master@{#301307}

[leviw_travelin_and_unemployed, 2014-10-27 03:19:56]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/679973003/ by leviw@chromium.org.

The reason for reverting is: This appears to break the entire world as far as
LayoutTests are concerned. Here's a small sample:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec....

[bokan, 2014-10-28 21:06:46]

The CQ bit was checked by bokan@chromium.org

[bokan, 2014-10-28 21:07:14]

Landing this Android-only while I sort out layout test breakages.

[commit-bot: I haz the power, 2014-10-28 21:07:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665963002/100001

[commit-bot: I haz the power, 2014-10-28 22:11:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-28 22:11:59]

Patchset 6 (id:??) landed as
https://crrev.com/edb0ccdf75d9133adfcf9d3ef28c81f8075a7746
Cr-Commit-Position: refs/heads/master@{#301722}