mac: Fix bug where finder window extends past bottom of screen.

mac: Fix bug where finder window extends past bottom of screen.

AppKit is responsible for determining the height of the NSSavePanel and
NSOpenPanel. It will never pick a height that causes the panel to be taller
than the screen, but it may pick a height that requires the panel to be
positioned near the top of its presenting window. Chrome's logic for
positioning panels did not take this into consideration, so it was possible to
position a panel that extended past the bottom of the screen.

This CL fixes this oversight.

BUG=423635
Committed: https://crrev.com/b5a19d4ffc9184ec221d46a88b4afa5071eb1527
Cr-Commit-Position: refs/heads/master@{#301533}

[erikchen, 2014-10-24 22:40:55]

Patchset #1 (id:1) has been deleted

[erikchen, 2014-10-24 22:56:28]

Patchset #1 (id:20001) has been deleted

[erikchen, 2014-10-24 22:57:00]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2014-10-24 22:57:01]

rsesek: Please review.

[Robert Sesek, 2014-10-27 15:41:23]

Is it possible to write a test for this? I think there's a browsertest already
about sheet positioning.

https://codereview.chromium.org/665933005/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/665933005/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:207: CGFloat
desiredY = defaultSheetRect.origin.y;
naming: desiredY -> defaultSheetY

[erikchen, 2014-10-27 23:18:13]

rsesek: PTAL

I updated the browser test to also test for this edge case.

https://codereview.chromium.org/665933005/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/665933005/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:207: CGFloat
desiredY = defaultSheetRect.origin.y;
On 2014/10/27 15:41:22, Robert Sesek wrote:
> naming: desiredY -> defaultSheetY

Done.

[Robert Sesek, 2014-10-27 23:20:56]

LGTM

[erikchen, 2014-10-27 23:42:16]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:46:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665933005/60001

[commit-bot: I haz the power, 2014-10-28 01:10:59]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2014-10-28 01:11:48]

Patchset 2 (id:??) landed as
https://crrev.com/b5a19d4ffc9184ec221d46a88b4afa5071eb1527
Cr-Commit-Position: refs/heads/master@{#301533}