mac: Fix bug where finder window extends past bottom of screen.

chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #import "base/mac/mac_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 22 matching lines @@
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_utils.h"
 #import "testing/gtest_mac.h"
+#import "third_party/ocmock/OCMock/OCMock.h"
 #import "ui/base/cocoa/nsview_additions.h"
 #include "ui/gfx/animation/slide_animation.h"
 
 namespace {
 
+// Creates a mock of an NSWindow that has the given |frame|.
+id MockWindowWithFrame(NSRect frame) {
+  id window = [OCMockObject mockForClass:[NSWindow class]];
+  NSValue* window_frame =
+      [NSValue valueWithBytes:&frame objCType:@encode(NSRect)];
+  [[[window stub] andReturnValue:window_frame] frame];
+  return window;
+}
+
 void CreateProfileCallback(const base::Closure& quit_closure,
                            Profile* profile,
                            Profile::CreateStatus status) {
   EXPECT_TRUE(profile);
   EXPECT_NE(Profile::CREATE_STATUS_LOCAL_FAIL, status);
   EXPECT_NE(Profile::CREATE_STATUS_REMOTE_FAIL, status);
   // This will be called multiple times. Wait until the profile is initialized
   // fully to quit the loop.
   if (status == Profile::CREATE_STATUS_INITIALIZED)
     quit_closure.Run();
@@ skipping 417 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, SheetPosition) {
   ASSERT_TRUE([controller() isKindOfClass:[BrowserWindowController class]]);
   EXPECT_TRUE([controller() isTabbedWindow]);
   EXPECT_TRUE([controller() hasTabStrip]);
   EXPECT_FALSE([controller() hasTitleBar]);
   EXPECT_TRUE([controller() hasToolbar]);
   EXPECT_FALSE([controller() isBookmarkBarVisible]);
 
   NSRect defaultAlertFrame = NSMakeRect(0, 0, 300, 200);
+  id sheet = MockWindowWithFrame(defaultAlertFrame);
   NSWindow* window = browser()->window()->GetNativeWindow();
   NSRect alertFrame = [controller() window:window
                          willPositionSheet:nil
                                  usingRect:defaultAlertFrame];
   NSRect toolbarFrame = [[[controller() toolbarController] view] frame];
   EXPECT_EQ(NSMinY(alertFrame), NSMinY(toolbarFrame));
 
   // Open sheet with normal browser window, persistent bookmark bar.
   chrome::ToggleBookmarkBarWhenVisible(browser()->profile());
   EXPECT_TRUE([controller() isBookmarkBarVisible]);
   alertFrame = [controller() window:window
-                  willPositionSheet:nil
+                  willPositionSheet:sheet
                           usingRect:defaultAlertFrame];
   NSRect bookmarkBarFrame = [[[controller() bookmarkBarController] view] frame];
   EXPECT_EQ(NSMinY(alertFrame), NSMinY(bookmarkBarFrame));
 
+  // If the sheet is too large, it should be positioned at the top of the
+  // window.
+  defaultAlertFrame = NSMakeRect(0, 0, 300, 2000);
+  sheet = MockWindowWithFrame(defaultAlertFrame);
+  alertFrame = [controller() window:window
+                  willPositionSheet:sheet
+                          usingRect:defaultAlertFrame];
+  EXPECT_EQ(NSMinY(alertFrame), NSHeight([window frame]));
+
+  // Reset the sheet's size.
+  defaultAlertFrame = NSMakeRect(0, 0, 300, 200);
+  sheet = MockWindowWithFrame(defaultAlertFrame);
+
   // Make sure the profile does not have the bookmark visible so that
   // we'll create the shortcut window without the bookmark bar.
   chrome::ToggleBookmarkBarWhenVisible(browser()->profile());
   // Open application mode window.
   OpenAppShortcutWindow(browser()->profile(), GURL("about:blank"));
   Browser* popup_browser = BrowserList::GetInstance(
       chrome::GetActiveDesktop())->GetLastActive();
   NSWindow* popupWindow = popup_browser->window()->GetNativeWindow();
   BrowserWindowController* popupController =
       [BrowserWindowController browserWindowControllerForWindow:popupWindow];
   ASSERT_TRUE([popupController isKindOfClass:[BrowserWindowController class]]);
   EXPECT_FALSE([popupController isTabbedWindow]);
   EXPECT_FALSE([popupController hasTabStrip]);
   EXPECT_TRUE([popupController hasTitleBar]);
   EXPECT_FALSE([popupController isBookmarkBarVisible]);
   EXPECT_FALSE([popupController hasToolbar]);
 
   // Open sheet in an application window.
   [popupController showWindow:nil];
   alertFrame = [popupController window:popupWindow
-                     willPositionSheet:nil
+                     willPositionSheet:sheet
                              usingRect:defaultAlertFrame];
   EXPECT_EQ(NSMinY(alertFrame),
             NSHeight([[popupWindow contentView] frame]) -
             defaultAlertFrame.size.height);
 
   // Close the application window.
   popup_browser->tab_strip_model()->CloseSelectedTabs();
   [popupController close];
 }
 
@@ skipping 72 matching lines @@
   VerifyWindowControlsZOrder();
   [controller() removeOverlay];
   VerifyWindowControlsZOrder();
 
   // Toggle immersive fullscreen, then verify z order. In immersive fullscreen,
   // there are no window controls.
   [controller() enterImmersiveFullscreen];
   [controller() exitImmersiveFullscreen];
   VerifyWindowControlsZOrder();
 }