Several bugfixes in dart:io's handing of sockets

dart/runtime/bin/eventhandler.h

Index: dart/runtime/bin/eventhandler.h
diff --git a/dart/runtime/bin/eventhandler.h b/dart/runtime/bin/eventhandler.h
index 54845d0e3f3517e43a9170a8ac6c8e8312ffe272..4293c278278dea0de817a7191a0f894191d0c1c9 100644
--- a/dart/runtime/bin/eventhandler.h
+++ b/dart/runtime/bin/eventhandler.h
@@ -30,6 +30,11 @@ enum MessageFlags {
 };
 
 
+#define COMMAND_MASK(data) (data & ((1 << kCloseCommand) | \

[Søren Gjesse, 2014/10/22 07:23:51]

I think the COMMAND_MASK should just be the mask

  #define COMMAND_MASK ((1 << kCloseCommand) |(1 << kReturnTokenCommand))

and then use

  xxx & COMMAND_MASK

where it is used.

[kustermann, 2014/10/23 21:59:23]

Then it becomes more verbose & redundant on the call site. I made now a
COMMAND_MASK which is a real mask and a IS_COMMAND macro with others. 

+                                    (1 << kShutdownReadCommand) | \
+                                    (1 << kShutdownWriteCommand) | \
+                                    (1 << kReturnTokenCommand)))
+
 class TimeoutQueue {
  private:
   class Timeout {