Several bugfixes in dart:io's handing of sockets

dart/runtime/bin/eventhandler.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_EVENTHANDLER_H_
 #define BIN_EVENTHANDLER_H_
 
 #include "bin/builtin.h"
 #include "bin/isolate_data.h"
 
@@ skipping 12 matching lines @@
   kDestroyedEvent = 4,
   kCloseCommand = 8,
   kShutdownReadCommand = 9,
   kShutdownWriteCommand = 10,
   kReturnTokenCommand = 11,
   kListeningSocket = 16,
   kPipe = 17,
 };
 
 
+#define COMMAND_MASK(data) (data & ((1 << kCloseCommand) | \

[Søren Gjesse, 2014/10/22 07:23:51]

I think the COMMAND_MASK should just be the mask

  #define COMMAND_MASK ((1 << kCloseCommand) |(1 << kReturnTokenCommand))

and then use

  xxx & COMMAND_MASK

where it is used.

[kustermann, 2014/10/23 21:59:23]

Then it becomes more verbose & redundant on the call site. I made now a
COMMAND_MASK which is a real mask and a IS_COMMAND macro with others. 

+                                    (1 << kShutdownReadCommand) | \
+                                    (1 << kShutdownWriteCommand) | \
+                                    (1 << kReturnTokenCommand)))
+
 class TimeoutQueue {
  private:
   class Timeout {
    public:
     Timeout(Dart_Port port, int64_t timeout, Timeout* next)
         : port_(port), timeout_(timeout), next_(next) {}
 
     Dart_Port port() const { return port_; }
 
     int64_t timeout() const { return timeout_; }
@@ skipping 83 matching lines @@
 
  private:
   friend class EventHandlerImplementation;
   EventHandlerImplementation delegate_;
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_EVENTHANDLER_H_