Fix Android hit testing in a totally static page.

Fix Android hit testing in a totally static page.

Our Android hit testing walks up the tree and returns the highest
ancestor that's either (1) a leaf node, or (2) focusable and doesn't
have focusable children.

The bug is that (2) shouldn't include the root element of the tree, which
is indeed focusable. If there are no focusable elements on the page, we don't
want all hit tests to return the root - we want them to return the original
object hit.

BUG=424350
Committed: https://crrev.com/b46a0cf36cb6eaee8bd8bae17ceb227a5bb8ad92
Cr-Commit-Position: refs/heads/master@{#300007}

[dmazzoni, 2014-10-16 21:21:53]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2014-10-16 21:33:34]

lgtm

https://codereview.chromium.org/665513002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/665513002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_manager_android.cc:419:
while (ancestor && ancestor != GetRoot()) {
Would it be worthwhile pulling the result of GetRoot() out into a local pointer
to avoid calling the method repeatedly?

[dmazzoni, 2014-10-16 21:47:24]

https://codereview.chromium.org/665513002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/665513002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_manager_android.cc:419:
while (ancestor && ancestor != GetRoot()) {
On 2014/10/16 21:33:34, aboxhall wrote:
> Would it be worthwhile pulling the result of GetRoot() out into a local
pointer
> to avoid calling the method repeatedly?

The compiler ought to be smart enough to do this. Still might be a good idea if
GetRoot was known to be expensive, just in case - but it's cheap so I think it's
more concise like this.

[dmazzoni, 2014-10-16 21:47:31]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-10-16 21:48:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665513002/1

[commit-bot: I haz the power, 2014-10-16 23:32:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-16 23:32:59]

Patchset 1 (id:??) landed as
https://crrev.com/b46a0cf36cb6eaee8bd8bae17ceb227a5bb8ad92
Cr-Commit-Position: refs/heads/master@{#300007}