Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 665513002: Fix Android hit testing in a totally static page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iframe_no_bam
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index 0259faf4ac615a586215909a8b0c1dc22c1742e7..5b4541f56ed7c2ed428311ca5608f85250960971 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -416,7 +416,7 @@ void BrowserAccessibilityManagerAndroid::HandleHoverEvent(
BrowserAccessibilityAndroid* ancestor =
static_cast<BrowserAccessibilityAndroid*>(node->GetParent());
- while (ancestor) {
+ while (ancestor && ancestor != GetRoot()) {
aboxhall 2014/10/16 21:33:34 Would it be worthwhile pulling the result of GetRo
dmazzoni 2014/10/16 21:47:24 The compiler ought to be smart enough to do this.
if (ancestor->PlatformIsLeaf() ||
(ancestor->IsFocusable() && !ancestor->HasFocusableChild())) {
node = ancestor;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698