Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 665463003: gpu: Add CHROMIUM_image support to in-process command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-gpu-memory-buffer-factory-to-gpu-image-factory
Patch Set: make code more consistent with command buffer proxy Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
index 7e503a5dafa04d6939ba01dad7797fc856da9943..3f6a319f069dd5aabcac26c506f15670fae329b1 100644
--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
@@ -76,11 +76,13 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
private:
WebGraphicsContext3DInProcessCommandBufferImpl(
- scoped_ptr< ::gpu::GLInProcessContext> context,
+ scoped_ptr<::gpu::GLInProcessContext> context,
const blink::WebGraphicsContext3D::Attributes& attributes,
bool lose_context_when_out_of_memory,
bool is_offscreen,
- gfx::AcceleratedWidget window);
+ gfx::AcceleratedWidget window,
+ ::gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
+ ::gpu::ImageFactory* image_factory);
no sievers 2014/10/17 21:16:50 Do we need these changes? It's weird in the constr
reveman 2014/10/17 22:36:17 Right, this must have been confusing :) Removed th
void OnContextLost();
@@ -102,6 +104,9 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
scoped_ptr< ::gpu::GLInProcessContext> context_;
// The GLES2Implementation we use for OpenGL rendering.
::gpu::gles2::GLES2Implementation* real_gl_;
+
+ ::gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager_;
+ ::gpu::ImageFactory* image_factory_;
};
} // namespace gpu

Powered by Google App Engine
This is Rietveld 408576698