Add chrome://flags for cloud import.

Add chrome://flags for cloud import.

+isherman for the histograms.xml change.

BUG=420680
Committed: https://crrev.com/451de88298a4bca3c8afd5db1faed46484147169
Cr-Commit-Position: refs/heads/master@{#300767}

[Steve McKay, 2014-10-21 19:19:42]

smckay@chromium.org changed reviewers:
+ jhawkins@chromium.org

[James Hawkins, 2014-10-21 20:08:58]

https://codereview.chromium.org/665343003/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/665343003/diff/1/chromeos/chromeos_switches.c...
chromeos/chromeos_switches.cc:82: const char kEnableCloudImport[] =
"enable-could-import";
s/could/cloud/

[Steve McKay, 2014-10-21 20:10:02]

smckay@chromium.org changed reviewers:
+ zelidrag@chromium.org

[Steve McKay, 2014-10-21 20:13:31]

+zeldrag for the ChromeOS changes.

https://codereview.chromium.org/665343003/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/665343003/diff/1/chromeos/chromeos_switches.c...
chromeos/chromeos_switches.cc:82: const char kEnableCloudImport[] =
"enable-could-import";
On 2014/10/21 20:08:58, James Hawkins wrote:
> s/could/cloud/

Done.

[stevenjb, 2014-10-21 20:14:11]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2014-10-21 20:14:11]

This doesn't appear to be used yet? I assume the implementation is forthcoming?
Generally I would prefer to include this with the initial implementation, it is
a small enough additional change.

https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6127: +        Allows the user to easily
import content to the cloud.
s/to the cloud/from the cloud/ ?

[Steve McKay, 2014-10-21 20:22:38]

On 2014/10/21 20:14:11, stevenjb wrote:
> This doesn't appear to be used yet? I assume the implementation is
forthcoming?
> Generally I would prefer to include this with the initial implementation, it
is
> a small enough additional change.

There are two of us working on this feature and I pulled a ticket to land the
flag. I could hold off for other work, but that'll introduce a race condition
between me and the other engineer (Ben).

Also, we're working with folks in the Tokyo office. Substantial changes needing
their review will require at least 1-day turnaround. So bite-sized CLs that
don't require their review seem like a good idea.

>
https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
> chrome/app/generated_resources.grd:6127: +        Allows the user to easily
> import content to the cloud.
> s/to the cloud/from the cloud/ ?

to the cloud...as in backup.

[James Hawkins, 2014-10-21 21:24:11]

Steve, can you send me a link to the design doc?  I'm most interested in seeing
which places the code is going to live.

[James Hawkins, 2014-10-21 21:28:02]

lgtm

[stevenjb, 2014-10-21 21:38:43]

On 2014/10/21 20:22:38, Steve McKay wrote:
> On 2014/10/21 20:14:11, stevenjb wrote:
> > This doesn't appear to be used yet? I assume the implementation is
> forthcoming?
> > Generally I would prefer to include this with the initial implementation, it
> is
> > a small enough additional change.
> 
> There are two of us working on this feature and I pulled a ticket to land the
> flag. I could hold off for other work, but that'll introduce a race condition
> between me and the other engineer (Ben).
> 
> Also, we're working with folks in the Tokyo office. Substantial changes
needing
> their review will require at least 1-day turnaround. So bite-sized CLs that
> don't require their review seem like a good idea.
> 
> >
>
https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
> > File chrome/app/generated_resources.grd (right):
> > 
> >
>
https://codereview.chromium.org/665343003/diff/1/chrome/app/generated_resourc...
> > chrome/app/generated_resources.grd:6127: +        Allows the user to easily
> > import content to the cloud.
> > s/to the cloud/from the cloud/ ?
> 
> to the cloud...as in backup.

I find this naming confusing then. Generally one "imports from" something, or
"exports to" something. I'll go ahead and lgtm this CL, but you might want to
reconsider the naming; I doubt I am going to be the only one confused by this.

[Steve McKay, 2014-10-21 21:46:27]

smckay@chromium.org changed reviewers:
- zelidrag@chromium.org

[Steve McKay, 2014-10-21 22:13:02]

Renamed to use "backup" in lieu of "import".

[stevenjb, 2014-10-21 22:39:29]

Thanks!
lgtm

https://codereview.chromium.org/665343003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/665343003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:6124: +        Enable cloud import.
s/import/backup

[Steve McKay, 2014-10-21 23:45:12]

https://codereview.chromium.org/665343003/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/665343003/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:6124: +        Enable cloud import.
On 2014/10/21 22:39:29, stevenjb wrote:
> s/import/backup

Done.

[Steve McKay, 2014-10-22 00:29:52]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2014-10-22 00:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665343003/60001

[commit-bot: I haz the power, 2014-10-22 02:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 02:51:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Steve McKay, 2014-10-22 18:07:01]

smckay@chromium.org changed reviewers:
+ isherman@chromium.org

[Steve McKay, 2014-10-22 18:22:48]

smckay@chromium.org changed reviewers:
+ mpearson@chromium.org
- isherman@chromium.org

[Steve McKay, 2014-10-22 18:22:49]

-Ilya (who's calendar makes him look unavailable)
+mpearson for histograms.xml change.

[Mark P, 2014-10-22 18:26:43]

lgtm

[Steve McKay, 2014-10-22 18:38:36]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2014-10-22 18:40:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665343003/80001

[commit-bot: I haz the power, 2014-10-22 18:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 18:53:04]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Steve McKay, 2014-10-22 19:55:00]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2014-10-22 19:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665343003/80001

[commit-bot: I haz the power, 2014-10-22 21:43:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-22 21:44:52]

Patchset 5 (id:??) landed as
https://crrev.com/451de88298a4bca3c8afd5db1faed46484147169
Cr-Commit-Position: refs/heads/master@{#300767}