Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 665253003: Remove SVGTextMetrics::m_glyph (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 1 month ago
Reviewers:
pdr., f(malita), eae
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove SVGTextMetrics::m_glyph This field was previously used for ligature and kerning lookups for SVG fonts. Since SVGTextMetrics::glyph() is no longer called we can remove the field and collapse some related code. BUG=242735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184376

Patch Set 1 #

Patch Set 2 : Drop WTFString.h include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M Source/core/rendering/svg/SVGTextLayoutEngineSpacing.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.cpp View 5 chunks +4 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
If you happen to have a bug for cleanups like this please edit the description.
6 years, 2 months ago (2014-10-24 14:41:11 UTC) #2
f(malita)
LGTM!
6 years, 2 months ago (2014-10-24 15:00:44 UTC) #4
pdr.
LGTM2. I added BUG=242735 just to keep these cleanups sort of together.
6 years, 2 months ago (2014-10-24 17:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665253003/20001
6 years, 2 months ago (2014-10-24 18:00:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 184376
6 years, 2 months ago (2014-10-24 18:04:05 UTC) #8
fs
6 years, 1 month ago (2014-10-27 08:58:28 UTC) #9
Message was sent while issue was closed.
On 2014/10/24 17:58:58, pdr wrote:
> LGTM2.
> 
> I added BUG=242735 just to keep these cleanups sort of together.

Noted. Thanks.

Powered by Google App Engine
This is Rietveld 408576698