Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 665123009: Distinguishing between audio and video stats in WebRTC telemetry. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
Reviewers:
Sami, Sami (do not use)
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Distinguishing between audio and video stats in WebRTC telemetry. We used to not be able to tell audio packetsSent from video packetsSent in the WebRTC stats reports, but with this patch we can. I use the fact that all video-send metrics will come with other video-send metrics, so we can classify a report based on what's in it (for instance, a report with audioInputLevel in it will be an audio-send report). This fixes buggy output where the code would merge data from send and receive metrics, for instance leading to packets received sequences like 10, 20, 15, 30, which doesn't make sense. BUG=412787 Committed: https://crrev.com/2e727fd948c84a61e5158ab3a53528a1a94fe151 Cr-Commit-Position: refs/heads/master@{#300653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M tools/perf/metrics/webrtc_stats.py View 4 chunks +26 lines, -3 lines 0 comments Download
M tools/perf/metrics/webrtc_stats_unittest.py View 5 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
phoglund_chromium
Hi! tonyg suggested you could review changes to metrics. Please review this one (which is ...
6 years, 2 months ago (2014-10-21 15:58:23 UTC) #3
Sami
lgtm. Thanks for extending the test too.
6 years, 2 months ago (2014-10-21 16:23:25 UTC) #5
phoglund_chromium
On 2014/10/21 16:23:25, Sami wrote: > lgtm. Thanks for extending the test too. Of course ...
6 years, 2 months ago (2014-10-22 07:06:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665123009/1
6 years, 2 months ago (2014-10-22 07:06:17 UTC) #8
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
6 years, 2 months ago (2014-10-22 07:06:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665123009/1
6 years, 2 months ago (2014-10-22 07:10:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 08:52:39 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 08:53:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e727fd948c84a61e5158ab3a53528a1a94fe151
Cr-Commit-Position: refs/heads/master@{#300653}

Powered by Google App Engine
This is Rietveld 408576698