Distinguishing between audio and video stats in WebRTC telemetry.

tools/perf/metrics/webrtc_stats_unittest.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 from metrics import webrtc_stats
 from telemetry.unittest import simple_mock
 
 
 SAMPLE_JSON = '''
 [[
    [
       {
          "googFrameHeightInput":"480",
          "googFrameWidthInput":"640",
+         "googFrameRateSent": "23",
          "packetsLost":"-1",
          "googRtt":"-1",
-         "packetsSent":"0",
+         "packetsSent":"1",
          "bytesSent":"0"
       },
       {
          "audioInputLevel":"2048",
          "googRtt":"-1",
          "googCodecName":"opus",
          "packetsSent":"4",
          "bytesSent":"0"
       }
    ],
    [
       {
          "googFrameHeightInput":"480",
          "googFrameWidthInput":"640",
+         "googFrameRateSent": "21",
          "packetsLost":"-1",
          "googRtt":"-1",
          "packetsSent":"8",
          "bytesSent":"6291"
       },
       {
          "audioInputLevel":"1878",
          "googRtt":"-1",
          "googCodecName":"opus",
          "packetsSent":"16",
          "bytesSent":"634"
       }
    ]
 ],
 [
    [
       {
+         "googFrameRateReceived": "23",
          "googDecodeMs":"0",
          "packetsReceived":"8",
          "googRenderDelayMs":"10",
          "googMaxDecodeMs":"0"
       }
    ],
    [
       {
+         "googFrameRateReceived": "23",
          "googDecodeMs":"14",
          "packetsReceived":"1234",
          "googRenderDelayMs":"102",
          "googMaxDecodeMs":"150"
       }
    ]
 ]]
 '''
 
 
@@ skipping 32 matching lines @@
     results = FakeResults(page)
     stats_metric.AddResults(tab, results)
     return results
 
   def testExtractsValuesAsTimeSeries(self):
     results = self._RunMetricOnJson(SAMPLE_JSON)
 
     self.assertTrue(results.received_values,
                     'Expected values for googDecodeMs and others, got none.')
 
-    # TODO(phoglund): this is actually a bug; make the metric clever enough to
-    # distinguish packetsSent on audio from packetsSent on video, etc.
+    # This also ensures we're clever enough to tell video packetsSent from audio
+    # packetsSent.
     self.assertEqual(results.received_values[0].values,
-                     [0.0, 4.0, 8.0, 16.0])
+                     [4.0, 16.0])
     self.assertEqual(results.received_values[1].values,
-                     [8.0, 1234.0])
+                     [1.0, 8.0])
 
   def testExtractsInterestingMetricsOnly(self):
     results = self._RunMetricOnJson(SAMPLE_JSON)
 
-    self.assertEqual(len(results.received_values), 4)
+    self.assertEqual(len(results.received_values), 5)
     self.assertEqual(results.received_values[0].name,
-                     'peer_connection_0_packets_sent',
+                     'peer_connection_0_audio_packets_sent',
                      'The result should be a ListOfScalarValues instance with '
                      'a name <peer connection id>_<statistic>.')
     self.assertEqual(results.received_values[1].name,
-                     'peer_connection_1_packets_received')
+                     'peer_connection_0_video_packets_sent')
     self.assertEqual(results.received_values[2].name,
-                     'peer_connection_1_goog_decode_ms')
+                     'peer_connection_1_video_goog_max_decode_ms')
     self.assertEqual(results.received_values[3].name,
-                     'peer_connection_1_goog_max_decode_ms')
+                     'peer_connection_1_video_packets_received')
+    self.assertEqual(results.received_values[4].name,
+                     'peer_connection_1_video_goog_decode_ms')
 
   def testReturnsIfJsonIsEmpty(self):
     results = self._RunMetricOnJson('[]')
     self.assertFalse(results.received_values)