[DevTools] Move SystemInfo domain to generated handler

[DevTools] Move SystemInfo domain to generated handler

BUG=405566
Committed: https://crrev.com/7a4981d733805ef210a8cbf70a858bf9914bbb45
Cr-Commit-Position: refs/heads/master@{#304010}

[vkuzkokov, 2014-10-20 15:53:07]

Patchset #1 (id:1) has been deleted

[vkuzkokov, 2014-10-24 14:01:47]

vkuzkokov@chromium.org changed reviewers:
+ dgozman@chromium.org

[vkuzkokov, 2014-10-24 14:02:15]

Patchset #1 (id:20001) has been deleted

[dgozman, 2014-10-28 10:19:57]

dgozman@chromium.org changed reviewers:
+ jbauman@chromium.org

[dgozman, 2014-10-28 10:19:58]

+jbauman for content/browser/gpu review.

devtools lgtm with nits

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/devtools_http_handler_impl.cc:177: // Takes ownership.
Obsolete comment.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
File content/browser/devtools/protocol/system_info_handler.cc (right):

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:23: virtual void
AddInt64(const char* name, int64 value) override {
nit: remove all "virtual" keywords from overrides per new guidelines.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:72: GPUDevice
GPUDeviceToDictionary(
I'd call this |GPUDeviceToProtocol| or something.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:105:
workarounds.push_back(workaround);
Why don't we have ListBuilder(vector<string>) ?

[vkuzkokov, 2014-10-28 11:57:50]

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/devtools_http_handler_impl.cc:177: // Takes ownership.
On 2014/10/28 10:19:58, dgozman wrote:
> Obsolete comment.

Done.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
File content/browser/devtools/protocol/system_info_handler.cc (right):

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:23: virtual void
AddInt64(const char* name, int64 value) override {
On 2014/10/28 10:19:58, dgozman wrote:
> nit: remove all "virtual" keywords from overrides per new guidelines.

Done.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:72: GPUDevice
GPUDeviceToDictionary(
On 2014/10/28 10:19:58, dgozman wrote:
> I'd call this |GPUDeviceToProtocol| or something.

Done.

https://codereview.chromium.org/665123002/diff/40001/content/browser/devtools...
content/browser/devtools/protocol/system_info_handler.cc:105:
workarounds.push_back(workaround);
On 2014/10/28 10:19:58, dgozman wrote:
> Why don't we have ListBuilder(vector<string>) ?

It has a single use (here) and should be discouraged to avoid unnecessary
copying.

[vkuzkokov, 2014-11-11 13:30:06]

jbauman, PTAL:
content/browser/gpu/

[jbauman, 2014-11-11 22:40:34]

lgtm

[vkuzkokov, 2014-11-12 09:23:38]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-12 09:23:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665123002/80001

[commit-bot: I haz the power, 2014-11-12 09:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 09:45:36]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[vkuzkokov, 2014-11-12 12:38:22]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-12 12:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665123002/120001

[commit-bot: I haz the power, 2014-11-12 13:32:59]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2014-11-12 13:34:04]

Patchset 5 (id:??) landed as
https://crrev.com/7c848788f642cd4c62cb11e890b4685f4a5f3b34
Cr-Commit-Position: refs/heads/master@{#303827}

[ernstm, 2014-11-12 18:26:22]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/723623003/ by ernstm@chromium.org.

The reason for reverting is: This probably brok the WinXP perf bots:
http://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%284%29/...

Speculatively reverting..

[vkuzkokov, 2014-11-13 10:21:03]

The CQ bit was checked by vkuzkokov@chromium.org

[commit-bot: I haz the power, 2014-11-13 10:22:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665123002/120001

[commit-bot: I haz the power, 2014-11-13 10:22:44]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2014-11-13 10:23:21]

Patchset 5 (id:??) landed as
https://crrev.com/7a4981d733805ef210a8cbf70a858bf9914bbb45
Cr-Commit-Position: refs/heads/master@{#304010}