Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/browser/devtools/browser_protocol.json

Issue 665123002: [DevTools] Move SystemInfo domain to generated handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browserProtocol
Patch Set: Rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/browser_protocol.json
diff --git a/content/browser/devtools/browser_protocol.json b/content/browser/devtools/browser_protocol.json
index 53ad99cd4465730f95cb870d7111fec7b8443348..51388e0aaa8002f5fc1f6f9f3283090d899cdefe 100644
--- a/content/browser/devtools/browser_protocol.json
+++ b/content/browser/devtools/browser_protocol.json
@@ -26,15 +26,6 @@
{ "name": "driverBugWorkarounds", "type": "array", "items": { "type": "string" }, "description": "An optional array of GPU driver bug workarounds." }
],
"description": "Provides information about the GPU(s) on the system."
- },
- {
- "id": "SystemInfo",
- "type": "object",
- "properties": [
- { "name": "gpu", "$ref": "GPUInfo", "description": "Information about the GPUs on the system." },
- { "name": "modelName", "type": "string", "description": "A platform-dependent description of the model of the machine. On Mac OS, this is, for example, 'MacBookPro 10.1'. Will be the empty string if not supported." }
- ],
- "description": "Provides information about the system."
}
],
"commands": [
@@ -42,7 +33,9 @@
"name": "getInfo",
"description": "Returns information about the system.",
"returns": [
- { "name": "info", "$ref": "SystemInfo", "description": "Information about the system." }
+ { "name": "gpu", "$ref": "GPUInfo", "description": "Information about the GPUs on the system." },
+ { "name": "modelName", "type": "string", "description": "A platform-dependent description of the model of the machine. On Mac OS, this is, for example, 'MacBookPro'. Will be the empty string if not supported." },
+ { "name": "modelVersion", "type": "string", "description": "A platform-dependent description of the version of the machine. On Mac OS, this is, for example, '10.1'. Will be the empty string if not supported." }
],
"handlers": ["browser"]
}
« no previous file with comments | « no previous file | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698