Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 665113002: Collect statistics from the importer on empty usernames and passwords from other browsers. (Closed)

Created:
6 years, 2 months ago by vasilii
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Collect statistics from the importer on empty usernames and passwords from other browsers. Also revert https://codereview.chromium.org/579813002 BUG=404012 Committed: https://crrev.com/547c1dd78570986435140b5f632ef927fd5168f8 Cr-Commit-Position: refs/heads/master@{#300656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/importer/in_process_importer_bridge.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vasilii
Hi Ilya, the statistics https://crash.corp.google.com/browse?q=product.version%3D%2740.0.2191.0%27%20OMIT%20RECORD%20IF%20SUM(CrashedStackTrace.StackFrame.FunctionName%20CONTAINS%20%27InProcessImporterBridge%3A%3ASetPasswordForm%27)%20%3D%200&stbtiq=&reportid=&index=0 shows that they are coming from importer. Please review.
6 years, 2 months ago (2014-10-20 16:32:48 UTC) #2
Ilya Sherman
LGTM, though I'm not sure what you're looking for at this point. IIRC, the in-process ...
6 years, 2 months ago (2014-10-21 01:38:49 UTC) #3
vasilii
It would be interesting to know which browser we are importing from.
6 years, 2 months ago (2014-10-22 08:44:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665113002/1
6 years, 2 months ago (2014-10-22 08:45:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 09:28:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 09:28:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/547c1dd78570986435140b5f632ef927fd5168f8
Cr-Commit-Position: refs/heads/master@{#300656}

Powered by Google App Engine
This is Rietveld 408576698