Collect statistics on importing empty usernames and passwords from other browsers.

Collect statistics on importing empty usernames and passwords from other browsers.

BUG=404012
Committed: https://crrev.com/0ecd334e26470f715650b3a38b95d2153fda1a9f
Cr-Commit-Position: refs/heads/master@{#295442}

[vasilii, 2014-09-17 15:34:44]

vasilii@chromium.org changed reviewers:
+ isherman@chromium.org

[vasilii, 2014-09-17 15:34:44]

Hi Ilya,

we know that occasionally empty usernames/passwords are imported from other
browsers. I want to collect the backtrace and then patch the importer.

[Ilya Sherman, 2014-09-17 18:35:12]

I think there's some chance that you'll need to also debug the
ExternalProcessImporterBridge, but I guess it's simpler to start with the
in-process one for now.  LGTM.

https://codereview.chromium.org/579813002/diff/1/chrome/browser/importer/in_p...
File chrome/browser/importer/in_process_importer_bridge.cc (right):

https://codereview.chromium.org/579813002/diff/1/chrome/browser/importer/in_p...
chrome/browser/importer/in_process_importer_bridge.cc:71:
base::debug::DumpWithoutCrashing();
Optional nit: Since the condition for this if-stmt is fairly long, I'd prefer
that you add curly braces.

[vasilii, 2014-09-18 08:54:34]

https://codereview.chromium.org/579813002/diff/1/chrome/browser/importer/in_p...
File chrome/browser/importer/in_process_importer_bridge.cc (right):

https://codereview.chromium.org/579813002/diff/1/chrome/browser/importer/in_p...
chrome/browser/importer/in_process_importer_bridge.cc:71:
base::debug::DumpWithoutCrashing();
On 2014/09/17 18:35:12, Ilya Sherman wrote:
> Optional nit: Since the condition for this if-stmt is fairly long, I'd prefer
> that you add curly braces.

Done.

[vasilii, 2014-09-18 08:54:46]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2014-09-18 08:55:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/579813002/20001

[commit-bot: I haz the power, 2014-09-18 10:08:20]

Committed patchset #2 (id:20001) as f56b8dd28a50cfd6f00ac2b51f6376debe067c24

[commit-bot: I haz the power, 2014-09-18 10:56:09]

Patchset 2 (id:??) landed as
https://crrev.com/0ecd334e26470f715650b3a38b95d2153fda1a9f
Cr-Commit-Position: refs/heads/master@{#295442}