Issue 6651019: Merge revisions 6871, 6981, and 7082 to the 3.0 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6651019: Merge revisions 6871, 6981, and 7082 to the 3.0 branch. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
sandholm, fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.0

Visibility:
Public.

Description

Merge revisions 6871, 6981, and 7082 to the 3.0 branch. These changes fix three different stack-height mismatch issues with deoptimization. Committed: http://code.google.com/p/v8/source/detail?r=7101

Patch Set 1 #

Patch Set 2 : Also change version.cc. #

Patch Set 3 : Change hydrogen.cc patch to match the original code more closely. #

Patch Set 4 : Fix cut-n-paste errors. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -39 lines)			Patch
M	src/arm/full-codegen-arm.cc	View		1 chunk	+17 lines, -11 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	3 chunks	+22 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+16 lines, -11 lines	0 comments	Download
M	src/version.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+16 lines, -10 lines	0 comments	Download
M	test/mjsunit/regress/regress-1167.js	View		2 chunks	+31 lines, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-1210.js	View		1 chunk	+48 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-1237.js	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sandholm

Merging the mentioned revisions to the 3.0 branch LGTM. I don't have any insight into ...

9 years, 9 months ago (2011-03-09 12:44:37 UTC) #2

LGTM.

Expand Messages | Collapse Messages