win: fixes for using vs 2013 toolchain

win: fixes for using vs 2013 toolchain

R=thakis@chromium.org
BUG=309197
Committed: https://code.google.com/p/gyp/source/detail?r=1780

[scottmg, 2013-11-08 21:43:38]

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/MSVSVersion.py
File pylib/gyp/MSVSVersion.py (left):

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/MSVSVersion.py#oldc...
pylib/gyp/MSVSVersion.py:394: if not msvs_version or 'e' not in msvs_version:
This was overly restrictive, I'm updating the toolchain script to support
building a "pro" based installation and there's no reason not to allow
non-Express as well here.

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py#n...
pylib/gyp/msvs_emulation.py:367: self.vs_version.short_name == '2013e'):
This was just a typo. :/

[Nico, 2013-11-09 04:20:30]

lgtm

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py#n...
pylib/gyp/msvs_emulation.py:367: self.vs_version.short_name == '2013e'):
if self.vs_version.short_name in ['2013', '2013e']:

?

[scottmg, 2013-11-09 04:47:32]

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py#n...
pylib/gyp/msvs_emulation.py:367: self.vs_version.short_name == '2013e'):
On 2013/11/09 04:20:31, Nico (ooo until Nov 12) wrote:
> if self.vs_version.short_name in ['2013', '2013e']:
> 
> ?

Done.

[scottmg, 2013-11-09 05:47:22]

Committed patchset #2 manually as r1780.