Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 66503004: win: fixes for using vs 2013 toolchain (Closed)

Created:
7 years, 1 month ago by scottmg
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

win: fixes for using vs 2013 toolchain R=thakis@chromium.org BUG=309197 Committed: https://code.google.com/p/gyp/source/detail?r=1780

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pylib/gyp/MSVSVersion.py View 1 chunk +2 lines, -2 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
https://codereview.chromium.org/66503004/diff/1/pylib/gyp/MSVSVersion.py File pylib/gyp/MSVSVersion.py (left): https://codereview.chromium.org/66503004/diff/1/pylib/gyp/MSVSVersion.py#oldcode394 pylib/gyp/MSVSVersion.py:394: if not msvs_version or 'e' not in msvs_version: This ...
7 years, 1 month ago (2013-11-08 21:43:38 UTC) #1
Nico
lgtm https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py#newcode367 pylib/gyp/msvs_emulation.py:367: self.vs_version.short_name == '2013e'): if self.vs_version.short_name in ['2013', '2013e']: ...
7 years, 1 month ago (2013-11-09 04:20:30 UTC) #2
scottmg
https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/66503004/diff/1/pylib/gyp/msvs_emulation.py#newcode367 pylib/gyp/msvs_emulation.py:367: self.vs_version.short_name == '2013e'): On 2013/11/09 04:20:31, Nico (ooo until ...
7 years, 1 month ago (2013-11-09 04:47:32 UTC) #3
scottmg
7 years, 1 month ago (2013-11-09 05:47:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1780.

Powered by Google App Engine
This is Rietveld 408576698