pylib/gyp/msvs_emulation.py - Issue 66503004: win: fixes for using vs 2013 toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 66503004: win: fixes for using vs 2013 toolchain (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: . Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/msvs_emulation.py

diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py

index 1d59e8beb2948c0489ae9e6a45deed37304bc873..3ac153dd862b40bf470e57f56238af33e81cf1a8 100644

--- a/pylib/gyp/msvs_emulation.py

+++ b/pylib/gyp/msvs_emulation.py

@@ -363,7 +363,7 @@ class MsvsSettings(object):

cl('AdditionalOptions', prefix='')

cflags.extend(['/FI' + f for f in self._Setting(

('VCCLCompilerTool', 'ForcedIncludeFiles'), config, default=[])])

- if self.vs_version.short_name == '2013' or self.vs_version == '2013e':

+ if self.vs_version.short_name in ('2013', '2013e'):

# New flag required in 2013 to maintain previous PDB behavior.

cflags.append('/FS')

# ninja handles parallelism by itself, don't have the compiler do it too.

« no previous file with comments | « pylib/gyp/MSVSVersion.py ('k') | no next file » | no next file with comments »