Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 665023002: Post-commit fixes for "stale-while-revalidate..." (Closed)

Created:
6 years, 2 months ago by Adam Rice
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang, mmenke
CC:
chromium-reviews, rvargas (doing something else)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Post-commit fixes for "stale-while-revalidate..." I accidentally committed http://crrev.com/455623003 before getting LGTM from mmenke@. This CL is for additional fixes that he requested. BUG=348877 TEST=net_unittests Committed: https://crrev.com/4373698a495a4949e673f885bfc9ed2da0afb1d3 Cr-Commit-Position: refs/heads/master@{#302056}

Patch Set 1 #

Patch Set 2 : Make it compile. Also remove gratuitous = 0. #

Patch Set 3 : Rename stucture members. #

Total comments: 5

Patch Set 4 : Make DCHECK_EQ work for TimeDelta objects. #

Total comments: 6

Patch Set 5 : Revert changes from last patch, but add braces. #

Total comments: 4

Patch Set 6 : Changes requested by thestig@ #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M chrome/browser/io_thread.cc View 1 2 3 4 5 6 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 5 6 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_response_headers.h View 1 2 3 chunks +7 lines, -9 lines 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 4 6 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 27 (7 generated)
Adam Rice
6 years, 2 months ago (2014-10-20 09:32:19 UTC) #2
mmenke
LGTM https://codereview.chromium.org/665023002/diff/40001/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): https://codereview.chromium.org/665023002/diff/40001/net/http/http_response_headers.cc#newcode1024 net/http/http_response_headers.cc:1024: DCHECK(lifetimes.staleness == TimeDelta()); Also, seems safest to use ...
6 years, 2 months ago (2014-10-20 14:41:09 UTC) #3
Adam Rice
PTAL. https://codereview.chromium.org/665023002/diff/40001/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): https://codereview.chromium.org/665023002/diff/40001/net/http/http_response_headers.cc#newcode1024 net/http/http_response_headers.cc:1024: DCHECK(lifetimes.staleness == TimeDelta()); On 2014/10/20 14:41:08, mmenke wrote: ...
6 years, 2 months ago (2014-10-21 09:26:14 UTC) #4
mmenke
I suggest moving the base/ changes into another CL - seems a bit far removed ...
6 years, 2 months ago (2014-10-21 14:20:09 UTC) #5
mmenke
https://codereview.chromium.org/665023002/diff/60001/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): https://codereview.chromium.org/665023002/diff/60001/net/http/http_response_headers.cc#newcode23 net/http/http_response_headers.cc:23: #include "base/time/time_logging.h" I wonder about requiring this include - ...
6 years, 2 months ago (2014-10-21 14:22:00 UTC) #6
mmenke
On 2014/10/21 14:22:00, mmenke wrote: > https://codereview.chromium.org/665023002/diff/60001/net/http/http_response_headers.cc > File net/http/http_response_headers.cc (right): > > https://codereview.chromium.org/665023002/diff/60001/net/http/http_response_headers.cc#newcode23 > ...
6 years, 2 months ago (2014-10-21 17:15:20 UTC) #7
mmenke
LGTM
6 years, 2 months ago (2014-10-22 18:44:42 UTC) #8
Adam Rice
I moved the base/ changes to https://codereview.chromium.org/669083002/ and the DCHECK_EQ() statements that require them to ...
6 years, 2 months ago (2014-10-23 01:13:02 UTC) #9
Adam Rice
+shishir for chrome/browser/predictors/ OWNERS.
6 years, 2 months ago (2014-10-23 01:14:25 UTC) #11
Adam Rice
On 2014/10/23 01:14:25, Adam Rice wrote: > +shishir for chrome/browser/predictors/ OWNERS. ping shishir.
6 years, 1 month ago (2014-10-24 07:30:20 UTC) #12
Adam Rice
-shishir, +dominich for chrome/browser/predictors OWNERS.
6 years, 1 month ago (2014-10-28 03:36:36 UTC) #14
Adam Rice
ping dominich
6 years, 1 month ago (2014-10-30 06:09:21 UTC) #15
Adam Rice
-dominich, +thestig for review of chrome/browser/predictors/
6 years, 1 month ago (2014-10-30 06:20:48 UTC) #17
Lei Zhang
lgtm https://codereview.chromium.org/665023002/diff/80001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/665023002/diff/80001/chrome/browser/io_thread.cc#newcode315 chrome/browser/io_thread.cc:315: bool IsStaleWhileRevalidateEnabled(const CommandLine& command_line) { nit: base::CommandLine https://codereview.chromium.org/665023002/diff/80001/chrome/browser/io_thread.cc#newcode318 ...
6 years, 1 month ago (2014-10-30 06:39:02 UTC) #18
Adam Rice
https://codereview.chromium.org/665023002/diff/80001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/665023002/diff/80001/chrome/browser/io_thread.cc#newcode315 chrome/browser/io_thread.cc:315: bool IsStaleWhileRevalidateEnabled(const CommandLine& command_line) { On 2014/10/30 06:39:02, Lei ...
6 years, 1 month ago (2014-10-30 07:28:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665023002/120001
6 years, 1 month ago (2014-10-30 07:31:27 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/7922)
6 years, 1 month ago (2014-10-30 08:31:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665023002/120001
6 years, 1 month ago (2014-10-30 08:51:24 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 1 month ago (2014-10-30 09:15:58 UTC) #26
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 09:16:36 UTC) #27
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4373698a495a4949e673f885bfc9ed2da0afb1d3
Cr-Commit-Position: refs/heads/master@{#302056}

Powered by Google App Engine
This is Rietveld 408576698