Fixed a bug in the serialization of history::URLRow.

Fixed a bug in the serialization of history::URLRow.

This caused profile import to fail and crash Chromium on startup.

BUG=75526
TEST=Remove all the profile data, then start Chromium. It crashes immediately
during profile import. (only tested on mac).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77642

[Joao da Silva, 2011-03-09 15:45:50]

Fixed a bug in the serialization of history::URLRow for IPC, and in an IPC
macro.

I don't know exactly who to include to review this, so I've added whoever git
blamed on the affected lines. Please include other reviewers if appropriate.

Please review, this keeps crashing Chromium for me. It passes ipc_tests.

http://codereview.chromium.org/6650026/diff/1/chrome/browser/importer/importe...
File chrome/browser/importer/importer_messages.h (left):

http://codereview.chromium.org/6650026/diff/1/chrome/browser/importer/importe...
chrome/browser/importer/importer_messages.h:97: !ReadParam(m, iter,
&favicon_id))
The problem is that this param is Read, but is never written (see 10 lines
above). Since there is no FavIconID in URLRow, I've removed it.

http://codereview.chromium.org/6650026/diff/1/ipc/ipc_message_macros.h
File ipc/ipc_message_macros.h (left):

http://codereview.chromium.org/6650026/diff/1/ipc/ipc_message_macros.h#oldcod...
ipc/ipc_message_macros.h:302: IPC_MESSAGE_DECL(SYNC, CONTROL, msg_class, 5, 0,
(type1_in, type2_in, type3_in, type4_in, type5_in), ()))
Vim highlighted this while I was searching for the bug, and I'm including it in
this patch. Grep didn't find any usage of this macro, so I guess it hasn't been
a problem yet.

http://codereview.chromium.org/6650026/diff/1/ipc/ipc_message_macros.h#oldcod...
ipc/ipc_message_macros.h:392: IPC_MESSAGE_DECL(SYNC, ROUTED, msg_class, 5, 1,
(type1_in, type2_in, type3_in, type4_in, type5_in), ()))
Same as above.

[Joao da Silva, 2011-03-09 15:49:40]

Fixed a bug in the serialization of history::URLRow for IPC, and in an IPC
macro.

I don't know exactly who to include to review this, so I've added whoever git
blamed on the affected lines. Please include other reviewers if appropriate.

Please review, this keeps crashing Chromium for me. It passes ipc_tests.

[Miranda Callahan, 2011-03-09 17:12:54]

On 2011/03/09 15:49:40, joaodasilva wrote:
> Fixed a bug in the serialization of history::URLRow for IPC, and in an IPC
> macro.
> 
> I don't know exactly who to include to review this, so I've added whoever git
> blamed on the affected lines. Please include other reviewers if appropriate.
> 
> Please review, this keeps crashing Chromium for me. It passes ipc_tests.

Good catch, LGTM.

[Tom Sepez, 2011-03-09 18:13:29]

LGTM.  Thanks for catching my stray close paren in the unused macro.
This mismatch is exactly the problem I've been trying to solve with some recent
changes in ipc_message_macros to generate matching routines.

[Joao da Silva, 2011-03-10 09:02:33]

danno: can you commit this please?

On Wed, Mar 9, 2011 at 7:13 PM, <tsepez@chromium.org> wrote:

> LGTM.  Thanks for catching my stray close paren in the unused macro.
> This mismatch is exactly the problem I've been trying to solve with some
> recent
> changes in ipc_message_macros to generate matching routines.
>
>
> http://codereview.chromium.org/6650026/
>