Fixed a bug in the serialization of history::URLRow.

chrome/browser/importer/importer_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IMPORTER_IMPORTER_MESSAGES_H_
 #define CHROME_BROWSER_IMPORTER_IMPORTER_MESSAGES_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 68 matching lines @@
     WriteParam(m, p.last_visit());
     WriteParam(m, p.hidden());
   }
   static bool Read(const Message* m, void** iter, param_type* p) {
     history::URLID id;
     GURL url;
     string16 title;
     int visit_count, typed_count;
     base::Time last_visit;
     bool hidden;
-    history::FavIconID favicon_id;
     if (!ReadParam(m, iter, &id) ||
         !ReadParam(m, iter, &url) ||
         !ReadParam(m, iter, &title) ||
         !ReadParam(m, iter, &visit_count) ||
         !ReadParam(m, iter, &typed_count) ||
         !ReadParam(m, iter, &last_visit) ||
-        !ReadParam(m, iter, &hidden) ||
-        !ReadParam(m, iter, &favicon_id))

[Joao da Silva, 2011/03/09 15:45:50]

The problem is that this param is Read, but is never written (see 10 lines
above). Since there is no FavIconID in URLRow, I've removed it.

+        !ReadParam(m, iter, &hidden))
       return false;
     *p = history::URLRow(url, id);
     p->set_title(title);
     p->set_visit_count(visit_count);
     p->set_typed_count(typed_count);
     p->set_last_visit(last_visit);
     p->set_hidden(hidden);
     return true;
   }
   static void Log(const param_type& p, std::string* l) {
@@ skipping 252 matching lines @@
   static void Log(const param_type& p, std::string* l) {
     l->append("<TemplateURL>");
   }
 };
 
 }  // namespace IPC
 
 #include "chrome/browser/importer/importer_messages_internal.h"
 
 #endif  // CHROME_BROWSER_IMPORTER_IMPORTER_MESSAGES_H_