Source/core/inspector/InspectorAnimationAgent.h - Issue 664993002: Devtools Animations: Display keyframes for CSS Animations in inspector

Unified Diff: Source/core/inspector/InspectorAnimationAgent.h

Issue 664993002: Devtools Animations: Display keyframes for CSS Animations in inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/css/CSSAnimations.h ('K') | « Source/core/animation/css/CSSAnimations.cpp ('k') | Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | Source/core/inspector/InspectorAnimationAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorAnimationAgent.h

diff --git a/Source/core/inspector/InspectorAnimationAgent.h b/Source/core/inspector/InspectorAnimationAgent.h

index 5f0fcb63a68320888866bc05f7999ef3ffe82efe..1129d502df5bf2d5e1d3cb212304d05a03935fe9 100644

--- a/Source/core/inspector/InspectorAnimationAgent.h

+++ b/Source/core/inspector/InspectorAnimationAgent.h

@@ -6,6 +6,7 @@

#define InspectorAnimationAgent_h

#include "core/InspectorFrontend.h"

+#include "core/css/CSSKeyframesRule.h"

#include "core/inspector/InspectorBaseAgent.h"

#include "wtf/PassOwnPtr.h"

#include "wtf/text/WTFString.h"

@@ -14,6 +15,7 @@ namespace blink {

class AnimationNode;

class AnimationPlayer;

+class Element;

class InspectorDOMAgent;

class InspectorAnimationAgent final : public InspectorBaseAgent<InspectorAnimationAgent>, public InspectorBackendDispatcher::AnimationCommandHandler {

@@ -45,9 +47,12 @@ private:

InspectorAnimationAgent(InspectorDOMAgent*);

String playerId(AnimationPlayer&);

+ PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&, PassRefPtr<TypeBuilder::Animation::KeyframesRule>);

pfeldman 2014/10/23 06:37:00 static builders are typically defined using non-cl

samli 2014/10/24 05:06:19 Done.

PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&);

- PassRefPtr<TypeBuilder::Animation::AnimationNode> buildObjectForAnimationNode(AnimationNode&);

+ PassRefPtr<TypeBuilder::Animation::AnimationNode> buildObjectForAnimationNode(AnimationNode*);

+ PassRefPtr<TypeBuilder::Animation::KeyframesRule> getObjectForStyleRuleKeyframes(const Element&, const AnimationPlayer&);

pfeldman 2014/10/23 06:37:00 There are no "get" prefixes in blink. The only one

samli 2014/10/24 05:06:19 Done.

+ PassRefPtr<TypeBuilder::Animation::KeyframesRule> buildObjectForStyleRuleKeyframes(const StyleRuleKeyframes*);

+ PassRefPtr<TypeBuilder::Animation::KeyframeStyle> buildObjectForStyleKeyframe(StyleKeyframe*);

RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;

InspectorFrontend::Animation* m_frontend;