Devtools Animations: Display keyframes for CSS Animations in inspector

Source/core/inspector/InspectorAnimationAgent.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef InspectorAnimationAgent_h
 #define InspectorAnimationAgent_h
 
 #include "core/InspectorFrontend.h"
+#include "core/css/CSSKeyframesRule.h"
 #include "core/inspector/InspectorBaseAgent.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class AnimationNode;
 class AnimationPlayer;
+class Element;
 class InspectorDOMAgent;
 
 class InspectorAnimationAgent final : public InspectorBaseAgent<InspectorAnimationAgent>, public InspectorBackendDispatcher::AnimationCommandHandler {
     WTF_MAKE_NONCOPYABLE(InspectorAnimationAgent);
 public:
     static PassOwnPtrWillBeRawPtr<InspectorAnimationAgent> create(InspectorDOMAgent* domAgent)
     {
         return adoptPtrWillBeNoop(new InspectorAnimationAgent(domAgent));
     }
 
@@ skipping 11 matching lines @@
 
     // Methods for other agents to use.
     AnimationPlayer* assertAnimationPlayer(ErrorString*, const String& id);
 
     virtual void trace(Visitor*) override;
 
 private:
     InspectorAnimationAgent(InspectorDOMAgent*);
 
     String playerId(AnimationPlayer&);
-
+    PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&, PassRefPtr<TypeBuilder::Animation::KeyframesRule>);

[pfeldman, 2014/10/23 06:37:00]

static builders are typically defined using non-class static functions within
.cpp.

[samli, 2014/10/24 05:06:19]

Done.

     PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&);
-    PassRefPtr<TypeBuilder::Animation::AnimationNode> buildObjectForAnimationNode(AnimationNode&);
+    PassRefPtr<TypeBuilder::Animation::AnimationNode> buildObjectForAnimationNode(AnimationNode*);
+    PassRefPtr<TypeBuilder::Animation::KeyframesRule> getObjectForStyleRuleKeyframes(const Element&, const AnimationPlayer&);

[pfeldman, 2014/10/23 06:37:00]

There are no "get" prefixes in blink. The only ones allowed are the ones from
the protocol.json and the ones with output params.

[samli, 2014/10/24 05:06:19]

Done.

+    PassRefPtr<TypeBuilder::Animation::KeyframesRule> buildObjectForStyleRuleKeyframes(const StyleRuleKeyframes*);
+    PassRefPtr<TypeBuilder::Animation::KeyframeStyle> buildObjectForStyleKeyframe(StyleKeyframe*);
 
     RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;
     InspectorFrontend::Animation* m_frontend;
     WillBeHeapHashMap<String, RefPtrWillBeMember<AnimationPlayer> > m_idToAnimationPlayer;
 };
 
 }
 
 #endif // InspectorAnimationAgent_h