Enabled the App Info dialog on the Extensions page by default

Enabled the App Info dialog on the Extensions page by default

Changed the flag '--enable-extension-info-dialog' to
'--disable-extension-info-dialog', which enables the App Info dialog as
the default dialog for displaying permissions on the extensions page.
Does not affect Mac platforms (where the old-style dialog is still
used).

Contains patches from issues 668163002 and 664473005, since the CQ
couldn't land them individually.

TBR=kalman,asvitkine,benwells,mpearson
BUG=395495
Committed: https://crrev.com/55550579b290a84ba21b2c38f0496689bbfa0c51
Cr-Commit-Position: refs/heads/master@{#301090}

[sashab, 2014-10-24 04:30:23]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 04:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/1

[commit-bot: I haz the power, 2014-10-24 04:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 04:41:01]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2014-10-24 05:03:40]

kochi@chromium.org changed reviewers:
+ kochi@chromium.org

[kochi, 2014-10-24 05:03:40]

not lgtm

Even after patching this CL, there is still one instance
of kEnableExtensionInfoDialog in
chrome/browser/ui/webui/extensions/extension_settings_handler.cc

[kochi, 2014-10-24 05:14:57]

On 2014/10/24 05:03:40, Takayoshi Kochi wrote:
> not lgtm
> 
> Even after patching this CL, there is still one instance
> of kEnableExtensionInfoDialog in
> chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Probably you missed the part in this commit.
This part might have to be reverted on trunk as well, but has not been reverted.

commit dd3485a9d6ace73e10d7a55fe24c57e7a42828a2
Author: sashab <sashab@chromium.org>
Date:   Fri Oct 24 10:22:59 2014

    Hide second 'Details' link on extensions page if App Info dialog used
    
    Hide the second 'Details' link on extensions page if the Extension
    Info Dialog is enabled. Screenshots on bug.
    
    BUG=395495
    
    Review URL: https://codereview.chromium.org/664473005
    
    Cr-Commit-Position: refs/heads/master@{#301017}

[sashab, 2014-10-24 05:31:54]

The CQ bit was checked by sashab@chromium.org

[sashab, 2014-10-24 05:31:55]

The CQ bit was unchecked by sashab@chromium.org

[sashab, 2014-10-24 05:35:12]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 05:36:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/40001

[commit-bot: I haz the power, 2014-10-24 05:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 05:36:07]

A disapproval has been posted by following reviewers: kochi@chromium.org.
Please make sure to get positive review before another CQ attempt.

[kochi, 2014-10-24 05:44:00]

lgtm

[kochi, 2014-10-24 05:44:19]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-10-24 05:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/40001

[commit-bot: I haz the power, 2014-10-24 07:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 07:14:29]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2014-10-24 07:26:04]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-10-24 07:26:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/40001

[commit-bot: I haz the power, 2014-10-24 08:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 08:29:19]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2014-10-24 09:27:30]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-10-24 09:27:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/40001

[commit-bot: I haz the power, 2014-10-24 10:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 10:35:52]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2014-10-24 11:59:27]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 11:59:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/40001

[sashab, 2014-10-24 12:22:29]

The CQ bit was unchecked by sashab@chromium.org

[sashab, 2014-10-24 12:22:36]

The CQ bit was unchecked by sashab@chromium.org

[sashab, 2014-10-24 12:23:56]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 12:24:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664933006/60001

[commit-bot: I haz the power, 2014-10-24 13:19:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-24 13:20:15]

Patchset 4 (id:??) landed as
https://crrev.com/55550579b290a84ba21b2c38f0496689bbfa0c51
Cr-Commit-Position: refs/heads/master@{#301090}