Hide second 'Details' link on extensions page if App Info dialog used

Hide second 'Details' link on extensions page if App Info dialog used

Hide the second 'Details' link on extensions page if the Extension
Info Dialog is enabled. Screenshots on bug.

BUG=395495
Committed: https://crrev.com/dd3485a9d6ace73e10d7a55fe24c57e7a42828a2
Cr-Commit-Position: refs/heads/master@{#301017}

[sashab, 2014-10-20 01:52:41]

sashab@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-10-20 18:32:25]

lgtm, though nit: your CL description is wordier than it needs to be, IMO :)

https://codereview.chromium.org/664473005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/664473005/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_list.js:311: if
(extension.homepageUrl) {
Seems like it would be simpler to just include "&&
!extension.enableExtensionInfoDialog" in this condition?

[sashab, 2014-10-23 00:50:44]

Turns out that code path is only used for extensions, but not apps. Added it to
a code path that is used for both - please re-review.

[not at google - send to devlin, 2014-10-23 13:58:16]

https://codereview.chromium.org/664473005/diff/40001/chrome/browser/resources...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/664473005/diff/40001/chrome/browser/resources...
chrome/browser/resources/extensions/extensions.js:24: *           
enableExtensionInfoDialog: boolean,
It looks to me like the object you're accessing enableExtensionInfoDialog on is
an ExtensionData, not an ExtensionDataReponse, so you should be adding this to
the other file.

[sashab, 2014-10-23 22:42:10]

Ahh, good find :) Done.

[not at google - send to devlin, 2014-10-23 22:44:35]

lgtm

[sashab, 2014-10-23 22:52:01]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-23 23:01:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664473005/60001

[commit-bot: I haz the power, 2014-10-24 01:23:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-24 01:23:47]

Patchset 4 (id:??) landed as
https://crrev.com/dd3485a9d6ace73e10d7a55fe24c57e7a42828a2
Cr-Commit-Position: refs/heads/master@{#301017}

[qyearsley, 2014-10-24 01:47:35]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/675683003/ by qyearsley@chromium.org.

The reason for reverting is: Caused compile failure:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu....

[sashab, 2014-10-24 03:56:44]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 03:57:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664473005/80001

[sashab, 2014-10-24 04:03:40]

The CQ bit was unchecked by sashab@chromium.org

[sashab, 2014-10-24 04:06:09]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-10-24 04:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664473005/80001

[commit-bot: I haz the power, 2014-10-24 04:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 04:19:28]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey, 2014-10-24 04:23:07]

On 2014/10/23 22:42:10, sasha_b wrote:
> Ahh, good find :) Done.

It seems this breaks compilation. See your buildbot:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
Or is the buildbot wrong somehow?