Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: extensions/common/features/base_feature_provider.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/api_feature.h ('k') | extensions/common/features/complex_feature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/base_feature_provider.h
diff --git a/extensions/common/features/base_feature_provider.h b/extensions/common/features/base_feature_provider.h
index d878acfae4ba7e7e8313976cdca14d3152a40150..e82c46d5ab819100b58be6150f83b96104f72b04 100644
--- a/extensions/common/features/base_feature_provider.h
+++ b/extensions/common/features/base_feature_provider.h
@@ -25,15 +25,14 @@ class BaseFeatureProvider : public FeatureProvider {
// provider create plain old Feature instances.
BaseFeatureProvider(const base::DictionaryValue& root,
FeatureFactory factory);
- virtual ~BaseFeatureProvider();
+ ~BaseFeatureProvider() override;
// Gets the feature |feature_name|, if it exists.
- virtual Feature* GetFeature(const std::string& feature_name) const override;
- virtual Feature* GetParent(Feature* feature) const override;
- virtual std::vector<Feature*> GetChildren(const Feature& parent) const
- override;
+ Feature* GetFeature(const std::string& feature_name) const override;
+ Feature* GetParent(Feature* feature) const override;
+ std::vector<Feature*> GetChildren(const Feature& parent) const override;
- virtual const std::vector<std::string>& GetAllFeatureNames() const override;
+ const std::vector<std::string>& GetAllFeatureNames() const override;
private:
typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
« no previous file with comments | « extensions/common/features/api_feature.h ('k') | extensions/common/features/complex_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698