Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: extensions/browser/value_store/testing_value_store.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.h ('k') | extensions/browser/view_type_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/value_store/testing_value_store.h
diff --git a/extensions/browser/value_store/testing_value_store.h b/extensions/browser/value_store/testing_value_store.h
index 20faa7d6ec65e24a5c28b3488bd30bbcead77f66..27df928813e6ac95f7997bbafe66230218b4dcd3 100644
--- a/extensions/browser/value_store/testing_value_store.h
+++ b/extensions/browser/value_store/testing_value_store.h
@@ -13,7 +13,7 @@
class TestingValueStore : public ValueStore {
public:
TestingValueStore();
- virtual ~TestingValueStore();
+ ~TestingValueStore() override;
// Sets the error code for requests. If OK, errors won't be thrown.
// Defaults to OK.
@@ -28,25 +28,24 @@ class TestingValueStore : public ValueStore {
int write_count() { return write_count_; }
// ValueStore implementation.
- virtual size_t GetBytesInUse(const std::string& key) override;
- virtual size_t GetBytesInUse(const std::vector<std::string>& keys) override;
- virtual size_t GetBytesInUse() override;
- virtual ReadResult Get(const std::string& key) override;
- virtual ReadResult Get(const std::vector<std::string>& keys) override;
- virtual ReadResult Get() override;
- virtual WriteResult Set(
- WriteOptions options,
- const std::string& key,
- const base::Value& value) override;
- virtual WriteResult Set(
- WriteOptions options, const base::DictionaryValue& values) override;
- virtual WriteResult Remove(const std::string& key) override;
- virtual WriteResult Remove(const std::vector<std::string>& keys) override;
- virtual WriteResult Clear() override;
+ size_t GetBytesInUse(const std::string& key) override;
+ size_t GetBytesInUse(const std::vector<std::string>& keys) override;
+ size_t GetBytesInUse() override;
+ ReadResult Get(const std::string& key) override;
+ ReadResult Get(const std::vector<std::string>& keys) override;
+ ReadResult Get() override;
+ WriteResult Set(WriteOptions options,
+ const std::string& key,
+ const base::Value& value) override;
+ WriteResult Set(WriteOptions options,
+ const base::DictionaryValue& values) override;
+ WriteResult Remove(const std::string& key) override;
+ WriteResult Remove(const std::vector<std::string>& keys) override;
+ WriteResult Clear() override;
// TestingValueStores can't get corrupted (they're all in-memory), so these
// just return true.
- virtual bool Restore() override;
- virtual bool RestoreKey(const std::string& key) override;
+ bool Restore() override;
+ bool RestoreKey(const std::string& key) override;
private:
scoped_ptr<ValueStore::Error> TestingError();
« no previous file with comments | « extensions/browser/value_store/leveldb_value_store.h ('k') | extensions/browser/view_type_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698