Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: extensions/browser/state_store.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/stash_backend_unittest.cc ('k') | extensions/browser/test_extension_registry_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/state_store.h
diff --git a/extensions/browser/state_store.h b/extensions/browser/state_store.h
index 5fc0370cb1574ada7cc9f1c53b0accc371746e76..19b3bd98a78effe49fa2f3406f75a2a5f4f82c41 100644
--- a/extensions/browser/state_store.h
+++ b/extensions/browser/state_store.h
@@ -38,7 +38,7 @@ class StateStore : public base::SupportsWeakPtr<StateStore>,
bool deferred_load);
// This variant is useful for testing (using a mock ValueStore).
StateStore(content::BrowserContext* context, scoped_ptr<ValueStore> store);
- virtual ~StateStore();
+ ~StateStore() override;
// Requests that the state store to be initialized after its usual delay. Can
// be explicitly called by an embedder when the embedder does not trigger the
@@ -71,9 +71,9 @@ class StateStore : public base::SupportsWeakPtr<StateStore>,
class DelayedTaskQueue;
// content::NotificationObserver
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
void Init();
@@ -85,16 +85,14 @@ class StateStore : public base::SupportsWeakPtr<StateStore>,
void RemoveKeysForExtension(const std::string& extension_id);
// ExtensionRegistryObserver implementation.
- virtual void OnExtensionUninstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- extensions::UninstallReason reason) override;
- virtual void OnExtensionWillBeInstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- bool is_update,
- bool from_ephemeral,
- const std::string& old_name) override;
+ void OnExtensionUninstalled(content::BrowserContext* browser_context,
+ const Extension* extension,
+ extensions::UninstallReason reason) override;
+ void OnExtensionWillBeInstalled(content::BrowserContext* browser_context,
+ const Extension* extension,
+ bool is_update,
+ bool from_ephemeral,
+ const std::string& old_name) override;
// Path to our database, on disk. Empty during testing.
base::FilePath db_path_;
« no previous file with comments | « extensions/browser/stash_backend_unittest.cc ('k') | extensions/browser/test_extension_registry_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698