Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: extensions/browser/api/web_request/web_request_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.h
diff --git a/extensions/browser/api/web_request/web_request_api.h b/extensions/browser/api/web_request/web_request_api.h
index ed5fbf77d395b2acd96be95d62e76ee6020b28ca..773cb5873453b694c471f74d9a5246b1073f5d91 100644
--- a/extensions/browser/api/web_request/web_request_api.h
+++ b/extensions/browser/api/web_request/web_request_api.h
@@ -63,13 +63,13 @@ class WebRequestAPI : public BrowserContextKeyedAPI,
public EventRouter::Observer {
public:
explicit WebRequestAPI(content::BrowserContext* context);
- virtual ~WebRequestAPI();
+ ~WebRequestAPI() override;
// BrowserContextKeyedAPI support:
static BrowserContextKeyedAPIFactory<WebRequestAPI>* GetFactoryInstance();
// EventRouter::Observer overrides:
- virtual void OnListenerRemoved(const EventListenerInfo& details) override;
+ void OnListenerRemoved(const EventListenerInfo& details) override;
private:
friend class BrowserContextKeyedAPIFactory<WebRequestAPI>;
@@ -495,10 +495,10 @@ class WebRequestInternalAddEventListenerFunction
WEBREQUESTINTERNAL_ADDEVENTLISTENER)
protected:
- virtual ~WebRequestInternalAddEventListenerFunction() {}
+ ~WebRequestInternalAddEventListenerFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class WebRequestInternalEventHandledFunction
@@ -508,7 +508,7 @@ class WebRequestInternalEventHandledFunction
WEBREQUESTINTERNAL_EVENTHANDLED)
protected:
- virtual ~WebRequestInternalEventHandledFunction() {}
+ ~WebRequestInternalEventHandledFunction() override {}
// Unblocks the network request and sets |error_| such that the developer
// console will show the respective error message. Use this function to handle
@@ -522,7 +522,7 @@ class WebRequestInternalEventHandledFunction
const std::string& error);
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class WebRequestHandlerBehaviorChangedFunction
@@ -532,15 +532,15 @@ class WebRequestHandlerBehaviorChangedFunction
WEBREQUEST_HANDLERBEHAVIORCHANGED)
protected:
- virtual ~WebRequestHandlerBehaviorChangedFunction() {}
+ ~WebRequestHandlerBehaviorChangedFunction() override {}
// ExtensionFunction:
- virtual void GetQuotaLimitHeuristics(
+ void GetQuotaLimitHeuristics(
extensions::QuotaLimitHeuristics* heuristics) const override;
// Handle quota exceeded gracefully: Only warn the user but still execute the
// function.
- virtual void OnQuotaExceeded(const std::string& error) override;
- virtual bool RunSync() override;
+ void OnQuotaExceeded(const std::string& error) override;
+ bool RunSync() override;
};
#endif // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_H_
« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter.h ('k') | extensions/browser/api/web_request/web_request_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698