Web MIDI: distributes MIDIPort information asynchronously

content/renderer/media/midi_message_filter.h

Index: content/renderer/media/midi_message_filter.h
diff --git a/content/renderer/media/midi_message_filter.h b/content/renderer/media/midi_message_filter.h
index 34cee3d1c26a59f44b9b3cc17e9f03835d203a7a..f2e1b2f4d04224dbcdc47199b189b1bffc740877 100644
--- a/content/renderer/media/midi_message_filter.h
+++ b/content/renderer/media/midi_message_filter.h
@@ -67,11 +67,13 @@ class CONTENT_EXPORT MidiMessageFilter : public IPC::MessageFilter {
 
   // Called when the browser process has approved (or denied) access to
   // MIDI hardware.
-  // TODO(toyoshim): MidiPortInfoList objects should be notified separately
-  // port by port.
-  void OnSessionStarted(media::MidiResult result,
-                        media::MidiPortInfoList inputs,
-                        media::MidiPortInfoList outputs);
+  void OnSessionStarted(media::MidiResult result);
+
+  // Called on two cases. One is just before OnSessionStarted() is called to

[palmer, 2014/10/22 22:55:12]

Documentation nit: How about this:

These functions are called in 2 cases: (1) Just before calling
|OnSessionStarted|, to notify the recipient about existing ports; (2) to notify
the recipient that a new device was connected and that new ports have been
created.

[Takashi Toyoshima, 2014/10/23 07:37:08]

Done.

+  // notify initial port information that already exist. The other is to add
+  // new port information when a new device is connected.
+  void OnAddInputPort(media::MidiPortInfo info);
+  void OnAddOutputPort(media::MidiPortInfo info);
 
   // Called when the browser process has sent MIDI data containing one or
   // more messages.
@@ -87,6 +89,9 @@ class CONTENT_EXPORT MidiMessageFilter : public IPC::MessageFilter {
   // Following methods, Handle*, run on |main_message_loop_|.
   void HandleClientAdded(media::MidiResult result);
 
+  void HandleAddInputPort(media::MidiPortInfo info);
+  void HandleAddOutputPort(media::MidiPortInfo info);
+
   void HandleDataReceived(uint32 port,
                           const std::vector<uint8>& data,
                           double timestamp);