Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: media/midi/midi_manager_usb_unittest.cc

Issue 664843002: Web MIDI: distributes MIDIPort information asynchronously (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifecycle
Patch Set: typo on ipc Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_manager_usb_unittest.cc
diff --git a/media/midi/midi_manager_usb_unittest.cc b/media/midi/midi_manager_usb_unittest.cc
index 0e5a3b55391511431e51c24b33c6390c973e96fa..8bf362f43abf42456fefdb8d540adc6ca4d427f5 100644
--- a/media/midi/midi_manager_usb_unittest.cc
+++ b/media/midi/midi_manager_usb_unittest.cc
@@ -79,6 +79,13 @@ class FakeMidiManagerClient : public MidiManagerClient {
logger_(logger) {}
virtual ~FakeMidiManagerClient() {}
+ virtual void AddInputPort(const MidiPortInfo& info) override {
+ input_ports_.push_back(info);
+ }
+ virtual void AddOutputPort(const MidiPortInfo& info) override {
+ output_ports_.push_back(info);
+ }
+
virtual void CompleteStartSession(MidiResult result) override {
complete_start_session_ = true;
result_ = result;
@@ -104,6 +111,8 @@ class FakeMidiManagerClient : public MidiManagerClient {
bool complete_start_session_;
MidiResult result_;
+ MidiPortInfoList input_ports_;
+ MidiPortInfoList output_ports_;
private:
Logger* logger_;
@@ -184,6 +193,9 @@ class MidiManagerUsbTest : public ::testing::Test {
}
}
+ const MidiPortInfoList& input_ports() { return client_->input_ports_; }
+ const MidiPortInfoList& output_ports() { return client_->output_ports_; }
+
scoped_ptr<MidiManagerUsbForTesting> manager_;
scoped_ptr<FakeMidiManagerClient> client_;
// Owned by manager_.
@@ -224,8 +236,8 @@ TEST_F(MidiManagerUsbTest, Initialize) {
RunCallbackUntilCallbackInvoked(true, &devices);
EXPECT_EQ(MIDI_OK, GetInitializationResult());
- ASSERT_EQ(1u, manager_->input_ports().size());
- ASSERT_EQ(2u, manager_->output_ports().size());
+ ASSERT_EQ(1u, input_ports().size());
+ ASSERT_EQ(2u, output_ports().size());
ASSERT_TRUE(manager_->input_stream());
std::vector<UsbMidiInputStream::JackUniqueKey> keys =
manager_->input_stream()->RegisteredJackKeysForTesting();
« content/renderer/media/midi_message_filter.cc ('K') | « media/midi/midi_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698