Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/renderer/media/midi_message_filter.h

Issue 664843002: Web MIDI: distributes MIDIPort information asynchronously (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifecycle
Patch Set: typo on ipc Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/midi_message_filter.h
diff --git a/content/renderer/media/midi_message_filter.h b/content/renderer/media/midi_message_filter.h
index b7678eeceb287f5d09fe3f66e6d2fdb65558a68a..84b3c25b0d0406dc65e5787c07bab86633b7d982 100644
--- a/content/renderer/media/midi_message_filter.h
+++ b/content/renderer/media/midi_message_filter.h
@@ -68,11 +68,13 @@ class CONTENT_EXPORT MidiMessageFilter : public IPC::MessageFilter {
// Called when the browser process has approved (or denied) access to
// MIDI hardware.
- // TODO(toyoshim): MidiPortInfoList objects should be notified separately
- // port by port.
- void OnSessionStarted(media::MidiResult result,
- media::MidiPortInfoList inputs,
- media::MidiPortInfoList outputs);
+ void OnSessionStarted(media::MidiResult result);
+
+ // Called on two cases. One is just before OnSessionStarted() is called to
+ // notify initial port information that already exist. The other is to add
+ // new port information when a new device is connected.
+ void OnAddInputPort(media::MidiPortInfo info);
+ void OnAddOutputPort(media::MidiPortInfo info);
// Called when the browser process has sent MIDI data containing one or
// more messages.

Powered by Google App Engine
This is Rietveld 408576698