Improve keyboard navigation on 'Manage search engines' options page

chrome/browser/resources/options/search_engine_manager_engine_list.js

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 4fe36511f337284ba059b8c4b2744bbc47531418..ebd458faddb54e80e63fdee517bca69749e2227c 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -139,6 +139,7 @@ cr.define('options.search_engines', function() {
 
       // And the URL column.
       var urlEl = this.createEditableTextCell(engine.url);
+      var makeDefaultButtonEl = null;

[Dan Beam, 2014/10/18 01:35:44]

probably don't need the "= null"

       // Extensions should not display a URL column.
       if (!engine.isExtension) {
         var urlWithButtonEl = this.ownerDocument.createElement('div');
@@ -150,7 +151,7 @@ cr.define('options.search_engines', function() {
         // re-ordering is implemented. When this is removed, remove the extra
         // div above.
         if (engine.canBeDefault) {
-          var makeDefaultButtonEl = this.ownerDocument.createElement('button');
+          makeDefaultButtonEl = this.ownerDocument.createElement('button');
           makeDefaultButtonEl.className =
               'custom-appearance list-inline-button';
           makeDefaultButtonEl.textContent =
@@ -192,6 +193,12 @@ cr.define('options.search_engines', function() {
             loadTimeData.getString('searchEngineTableURLPlaceholder');
       }
 
+      this.setFocusableColumnIndex(this.nameField_, 0);
+      this.setFocusableColumnIndex(this.keywordField_, 1);
+      this.setFocusableColumnIndex(this.urlField_, 2);
+      this.setFocusableColumnIndex(makeDefaultButtonEl, 3);
+      this.setFocusableColumnIndex(this.closeButtonElement, 4);
+      
       var fields = [this.nameField_, this.keywordField_, this.urlField_];
         for (var i = 0; i < fields.length; i++) {
         fields[i].oninput = this.startFieldValidation_.bind(this);