chrome/browser/resources/options/options_page.css - Issue 664583006: Improve keyboard navigation on 'Manage search engines' options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options_page.css

Issue 664583006: Improve keyboard navigation on 'Manage search engines' options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/inline_editable_list.js ('K') | « chrome/browser/resources/options/inline_editable_list.js ('k') | chrome/browser/resources/options/search_engine_manager_engine_list.js » ('j') | chrome/browser/resources/options/search_engine_manager_engine_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options_page.css

diff --git a/chrome/browser/resources/options/options_page.css b/chrome/browser/resources/options/options_page.css

index a2e4cf5a12b21285e823df221c4abab628c0198a..26fcb4b5630fb76624729110cefdba2e651d3816 100644

--- a/chrome/browser/resources/options/options_page.css

+++ b/chrome/browser/resources/options/options_page.css

@@ -311,15 +311,8 @@ list[type='text'][inlineeditable] input {

}

list > :not([editing]) [displaymode='edit'] {

- display: none;

-list > [editing] [displaymode='static'] {

- /* Don't use display:none because we need to keep an element focusable. */

- left: 0;

- pointer-events: none;

- position: absolute;

- visibility: hidden;

+ border: none;

+ background-color: rgb(255, 255, 255);

Dan Beam 2014/10/18 01:35:44 ^ why is this necessary? also, why not "white"?

}

list > [editing] input:invalid {