Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Issue 664583004: Mark NoOpGLSurface as surfaceless. (Closed)

Created:
6 years, 2 months ago by jbauman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, ccameron, hendrikw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mark NoOpGLSurface as surfaceless. Otherwise the decoder attempts to clear the nonexistent framebuffer, which causes an unexpected error and later a crash. BUG=424024 Committed: https://crrev.com/a760469552a117d620b37fbccf633f5216c2e0e5 Cr-Commit-Position: refs/heads/master@{#300042}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
jbauman
6 years, 2 months ago (2014-10-16 22:04:46 UTC) #2
ccameron
lgtm
6 years, 2 months ago (2014-10-16 22:06:47 UTC) #4
Ken Russell (switch to Gerrit)
LGTM
6 years, 2 months ago (2014-10-16 22:45:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583004/1
6 years, 2 months ago (2014-10-16 22:46:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/59531)
6 years, 2 months ago (2014-10-16 23:31:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583004/20001
6 years, 2 months ago (2014-10-17 00:06:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 02:00:48 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:01:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a760469552a117d620b37fbccf633f5216c2e0e5
Cr-Commit-Position: refs/heads/master@{#300042}

Powered by Google App Engine
This is Rietveld 408576698