Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1488313002: gpu: enable FRAMBUFFER_SRGB on desktop

Created:
5 years ago by hendrikw
Modified:
5 years ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: enable FRAMBUFFER_SRGB on desktop While enabling command buffer backend for skia, we ran into problems with the SRGB tests performing double conversion to SRGB while drawing. Enable FRAMBUFFER_SRGB on desktop to draw in the correct color space.

Patch Set 1 #

Patch Set 2 : mod comment #

Patch Set 3 : fix test #

Patch Set 4 : rebase #

Patch Set 5 : check for the extension before using #

Patch Set 6 : rebase, again #

Patch Set 7 : rebase, again again #

Patch Set 8 : merge again and again and again, wth, apply this patch, please!!!!! #

Patch Set 9 : make a new branch and try again, stupid git #

Patch Set 10 : checkout brand new tree, manually copy each change over, commit, upload #

Patch Set 11 : oops, copied one too many lines #

Patch Set 12 : no change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M gpu/command_buffer/service/feature_info.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +8 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
hendrikw
PTAL, thanks!
5 years ago (2015-12-01 23:58:11 UTC) #3
bajones
On 2015/12/01 23:58:11, hendrikw wrote: > PTAL, thanks! Happy to see such a simple fix, ...
5 years ago (2015-12-02 00:07:31 UTC) #4
hendrikw
This time -- with tests (if you can call it that)
5 years ago (2015-12-02 00:22:30 UTC) #5
bajones
On 2015/12/02 00:22:30, hendrikw wrote: > This time -- with tests (if you can call ...
5 years ago (2015-12-02 00:23:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488313002/40001
5 years ago (2015-12-02 17:43:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/148803)
5 years ago (2015-12-02 18:21:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488313002/40001
5 years ago (2015-12-02 21:34:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/138635)
5 years ago (2015-12-02 22:01:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488313002/60001
5 years ago (2015-12-02 22:20:02 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-02 22:28:34 UTC) #19
Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

Powered by Google App Engine
This is Rietveld 408576698